Skip to content

Browser ESM bundle require()s @react-native-async-storage/async-storage in getReactNativeAnonId() #1390

Description

@foisalislambd

Description

@metamask/sdk@0.33.1 dist/browser/es/metamask-sdk.js contains:

const t = require("@react-native-async-storage/async-storage").default;

inside getReactNativeAnonId(). Webpack/Next.js still tries to resolve it for web builds.

@react-native-async-storage/async-storage is only in devDependencies of @metamask/sdk.

Import trace (via wagmi)

@metamask/sdk/dist/browser/es/metamask-sdk.js
  ← @wagmi/connectors/dist/esm/metaMask.js
  ← wagmi/connectors
  ← @rainbow-me/rainbowkit

Expected

Browser bundle should not require() React Native packages. RN code should live only in dist/react-native/es.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions