From 633bbb555540320488bdc26e1281130a9a1a1c1d Mon Sep 17 00:00:00 2001 From: Maggie Hendry Date: Mon, 24 Aug 2026 18:34:06 +0100 Subject: [PATCH 1/3] Added code owners file list for Lakes, Surface, Veg3 RED Demography, Biogeochemistry --- .github/CODEOWNERS | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index b83c1168..5ed060a5 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -20,15 +20,15 @@ ############################################################################### # Science Module Leaders (informational) ############################################################################### -# Surface: John Edwards, Rich Ellis +# Surface: John Edwards # Hydrology: Nic Gedney, Sonja Folwell -# Vegetation: Lina Mercado, Karina Williams, Rebecca Oliver +# Vegetation: Lina Mercado, Rebecca Oliver # Veg3 RED Demography: Andy Wiltshire, Arthur Argles # Biogeochemistry: Eleanor Burke, Noah Smith # Biogenic fluxes: Garry Hayman, James Weber # Fire: Doug Kelley, Chantelle Burton # Lakes: Helen Johnson -# Evaluation: Nina Raoult, Siyuan Tian +# Evaluation: Heather Rumbold, Siyuan Tian # CABLE Science: Ian Harman, Claire Carouge # IMOGEN: Chris Huntingford, Eleanor Burke # @@ -59,3 +59,25 @@ etc/ @MetOffice/ssdteam **/control/shared/jules_water_resources_mod.F90 @maggiehendry **/control/shared/overbank_inundation_mod.F90 @maggiehendry **/io/dump/get_dim_info_mod.F90 @maggiehendry +**/science/flake/ @HelenRJohnson +**/control/shared/lake_mod.F90 @HelenRJohnson +**/initialisation/standalone/initial_conditions/flake_init_mod.F90 @HelenRJohnson +**/initialisation/standalone/ancillaries/init_flake_ancils_mod.F90 @HelenRJohnson +**/science/snow/ @JMEdwardsXtr +**/science/surface/ @JMEdwardsXtr +rose-meta/jules-shared/jules-snow/ @JMEdwardsXtr +rose-meta/jules-shared/jules-surface/ @JMEdwardsXtr +**/control/shared/next_gen_biogeochem_mod.F90 @mo-arthurargles +**/control/shared/veg3_field_mod.F90 @mo-arthurargles +**/initialisation/standalone/params/init_red_mod.F90 @mo-arthurargles +**/science/params/red_io_mod.F90 @mo-arthurargles +**/science/params/veg3_param_mod.F90 @mo-arthurargles +**/science/vegetation/veg3_litter_mod.F90 @mo-arthurargles +**/science/vegetation/veg3_red_dynamic_mod.F90 @mo-arthurargles +doc/source/namelists/red_parms.nml.rst @mo-arthurargles +**/control/shared/jules_soil_biogeochem_mod.F90 @eleanorgb +**/control/shared/next_gen_biogeochem_mod.F90 @eleanorgb +**/control/shared/soil_biogeochem_control_mod.F90 @eleanorgb +**/initialisation/standalone/init_soil_biogeochem_mod.F90 @eleanorgb +**/science/soil_biogeochem @eleanorgb +doc/source/namelists/jules_soil_biogeochem.nml.rst @eleanorgb \ No newline at end of file From d2b7dd764e8fc52f34d9a3602ace7656a26881f4 Mon Sep 17 00:00:00 2001 From: Maggie Hendry Date: Mon, 24 Aug 2026 18:40:06 +0100 Subject: [PATCH 2/3] Testing code ownership --- src/control/shared/jules_soil_biogeochem_mod.F90 | 1 + src/control/shared/next_gen_biogeochem_mod.F90 | 1 + src/science/flake/flake_mod.F90 | 2 +- src/science/snow/canopysnow_mod.F90 | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/control/shared/jules_soil_biogeochem_mod.F90 b/src/control/shared/jules_soil_biogeochem_mod.F90 index 4b6588f6..48cd31ca 100644 --- a/src/control/shared/jules_soil_biogeochem_mod.F90 +++ b/src/control/shared/jules_soil_biogeochem_mod.F90 @@ -8,6 +8,7 @@ ! ! [Met Office Ref SC0237] !******************************COPYRIGHT************************************** +! Testing code ownership file MODULE jules_soil_biogeochem_mod diff --git a/src/control/shared/next_gen_biogeochem_mod.F90 b/src/control/shared/next_gen_biogeochem_mod.F90 index b5619d3a..c2070854 100644 --- a/src/control/shared/next_gen_biogeochem_mod.F90 +++ b/src/control/shared/next_gen_biogeochem_mod.F90 @@ -8,6 +8,7 @@ ! Code Owner: Please refer to ModuleLeaders.txt ! This file belongs in Veg3 Ecosystem Demography ! *****************************COPYRIGHT**************************************** +! Testing code ownership file MODULE next_gen_biogeochem_mod diff --git a/src/science/flake/flake_mod.F90 b/src/science/flake/flake_mod.F90 index b88963b9..bf4e2c48 100644 --- a/src/science/flake/flake_mod.F90 +++ b/src/science/flake/flake_mod.F90 @@ -25,7 +25,7 @@ ! File %M% from Library %Q% ! Version %I% from %G% extracted: %H% !------------------------------------------------------------------------------ - +! Testing code ownership file MODULE flake !------------------------------------------------------------------------------ diff --git a/src/science/snow/canopysnow_mod.F90 b/src/science/snow/canopysnow_mod.F90 index ed428de9..aaf63251 100644 --- a/src/science/snow/canopysnow_mod.F90 +++ b/src/science/snow/canopysnow_mod.F90 @@ -11,6 +11,7 @@ ! Description: ! Partition snowfall into canopy interception, throughfall and unloading. +! Testing code ownership file ! Subroutine Interface: MODULE canopysnow_mod From ba245a32ff890a894feb107083c27431fc31eee6 Mon Sep 17 00:00:00 2001 From: Maggie Hendry Date: Mon, 24 Aug 2026 19:05:09 +0100 Subject: [PATCH 3/3] Revert "Testing code ownership" This reverts commit d2b7dd764e8fc52f34d9a3602ace7656a26881f4. --- src/control/shared/jules_soil_biogeochem_mod.F90 | 1 - src/control/shared/next_gen_biogeochem_mod.F90 | 1 - src/science/flake/flake_mod.F90 | 2 +- src/science/snow/canopysnow_mod.F90 | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/control/shared/jules_soil_biogeochem_mod.F90 b/src/control/shared/jules_soil_biogeochem_mod.F90 index 48cd31ca..4b6588f6 100644 --- a/src/control/shared/jules_soil_biogeochem_mod.F90 +++ b/src/control/shared/jules_soil_biogeochem_mod.F90 @@ -8,7 +8,6 @@ ! ! [Met Office Ref SC0237] !******************************COPYRIGHT************************************** -! Testing code ownership file MODULE jules_soil_biogeochem_mod diff --git a/src/control/shared/next_gen_biogeochem_mod.F90 b/src/control/shared/next_gen_biogeochem_mod.F90 index c2070854..b5619d3a 100644 --- a/src/control/shared/next_gen_biogeochem_mod.F90 +++ b/src/control/shared/next_gen_biogeochem_mod.F90 @@ -8,7 +8,6 @@ ! Code Owner: Please refer to ModuleLeaders.txt ! This file belongs in Veg3 Ecosystem Demography ! *****************************COPYRIGHT**************************************** -! Testing code ownership file MODULE next_gen_biogeochem_mod diff --git a/src/science/flake/flake_mod.F90 b/src/science/flake/flake_mod.F90 index bf4e2c48..b88963b9 100644 --- a/src/science/flake/flake_mod.F90 +++ b/src/science/flake/flake_mod.F90 @@ -25,7 +25,7 @@ ! File %M% from Library %Q% ! Version %I% from %G% extracted: %H% !------------------------------------------------------------------------------ -! Testing code ownership file + MODULE flake !------------------------------------------------------------------------------ diff --git a/src/science/snow/canopysnow_mod.F90 b/src/science/snow/canopysnow_mod.F90 index aaf63251..ed428de9 100644 --- a/src/science/snow/canopysnow_mod.F90 +++ b/src/science/snow/canopysnow_mod.F90 @@ -11,7 +11,6 @@ ! Description: ! Partition snowfall into canopy interception, throughfall and unloading. -! Testing code ownership file ! Subroutine Interface: MODULE canopysnow_mod