Skip to content

ValueError when loading DIC map in newer versions of numpy #157

Description

@rhysgt

Depending on subwindow size, PyVale can return subset_x and subset_y values in the csv file that are not an integer (ie 7.5 or 11.5)

Newer versions of numpy (v2.1.3 is fine, v2.5.2 breaks) are more strict about casting this directly to an integer, giving the following error:

ValueError: could not convert string '7.5' to int32 at row 0, column 1.

Currently we store the coordinate in memory so changing this to a float will occupy more memory. Is there a reason we keep this coordinates? We could just cast to a float instead (which is used for subwindow size calc) then not save the coordinates?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions