Locate grain function is slow due to re-running grain finding

[rhysgt]

Even after the find_grains function has been executed succesfully, the function executes again when using the locate_grain function, wasting a lot of time.

[mikesmic]

Is this on the dev branch I assume? Running a function directly will not save to the datastore. You have to 'generate' the data you want, for grains you would run:
ebsd_map.data.generate('grains', min_grain_size=10)

[mikesmic]

locate_grain should generate the grains automatically, so it should have only run at the first execution. I'll have a look at that

[rhysgt]

Yes on develop. Ah ok, maybe we should change the example notebook to use generate instead of find_grains? Sent from Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Michael Atkinson ***@***.***> Sent: Wednesday, July 10, 2024 4:59:39 PM To: MechMicroMan/DefDAP ***@***.***> Cc: Rhys Thomas ***@***.***>; Author ***@***.***> Subject: Re: [MechMicroMan/DefDAP] Locate grain function is slow due to re-running grain finding (Issue #129) Is this on the dev branch I assume? Running a function directly will not save to the datastore. You have to 'generate' the data you want, for grains you would run: ebsd_map.data.generate('grains', min_grain_size=10) — Reply to this email directly, view it on GitHub [github.com]<https://urldefense.com/v3/__https://github.com/MechMicroMan/DefDAP/issues/129*issuecomment-2220908954__;Iw!!PDiH4ENfjr2_Jw!BoXFEoxMhMf-9u_bJTpkV5kcAmONQ3vLFJqmN3-9Nzc4VEcDRrngFMApfUAtRIHIJMkv2M1vvx989s6s8UycsyRutGnOQue5pQ$>, or unsubscribe [github.com]<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEUI6KOZP3D7FTL3RVMDI43ZLVK6XAVCNFSM6AAAAABKVGQVICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQHEYDQOJVGQ__;!!PDiH4ENfjr2_Jw!BoXFEoxMhMf-9u_bJTpkV5kcAmONQ3vLFJqmN3-9Nzc4VEcDRrngFMApfUAtRIHIJMkv2M1vvx989s6s8UycsyRutGlcPLfvIw$>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[rhysgt]

And yes I think it does just generate the grains on first execution. Sent from Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Rhys Thomas ***@***.***> Sent: Wednesday, July 10, 2024 5:01:21 PM To: MechMicroMan/DefDAP ***@***.***>; MechMicroMan/DefDAP ***@***.***> Cc: Author ***@***.***> Subject: Re: [MechMicroMan/DefDAP] Locate grain function is slow due to re-running grain finding (Issue #129) Yes on develop. Ah ok, maybe we should change the example notebook to use generate instead of find_grains? Sent from Outlook for iOS<https://aka.ms/o0ukef>

________________________________ From: Michael Atkinson ***@***.***> Sent: Wednesday, July 10, 2024 4:59:39 PM To: MechMicroMan/DefDAP ***@***.***> Cc: Rhys Thomas ***@***.***>; Author ***@***.***> Subject: Re: [MechMicroMan/DefDAP] Locate grain function is slow due to re-running grain finding (Issue #129) Is this on the dev branch I assume? Running a function directly will not save to the datastore. You have to 'generate' the data you want, for grains you would run: ebsd_map.data.generate('grains', min_grain_size=10) — Reply to this email directly, view it on GitHub [github.com]<https://urldefense.com/v3/__https://github.com/MechMicroMan/DefDAP/issues/129*issuecomment-2220908954__;Iw!!PDiH4ENfjr2_Jw!BoXFEoxMhMf-9u_bJTpkV5kcAmONQ3vLFJqmN3-9Nzc4VEcDRrngFMApfUAtRIHIJMkv2M1vvx989s6s8UycsyRutGnOQue5pQ$>, or unsubscribe [github.com]<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEUI6KOZP3D7FTL3RVMDI43ZLVK6XAVCNFSM6AAAAABKVGQVICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQHEYDQOJVGQ__;!!PDiH4ENfjr2_Jw!BoXFEoxMhMf-9u_bJTpkV5kcAmONQ3vLFJqmN3-9Nzc4VEcDRrngFMApfUAtRIHIJMkv2M1vvx989s6s8UycsyRutGlcPLfvIw$>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[mikesmic]

It is updated in the main example notebook, not sure about the others