From 0723b5ed33b744cd3c71d46367123e312fc21b71 Mon Sep 17 00:00:00 2001 From: Dennis Felsing Date: Thu, 7 May 2026 05:13:53 +0000 Subject: [PATCH] balancerd: use single MetricsRegistry so alloc metrics are served Since #28056, `main()` registered jemalloc/alloc metrics into one MetricsRegistry while `run()` created a separate one for the HTTP `/metrics` endpoint, making the alloc metrics invisible. Pass the registry from `main()` into `run()` to match environmentd and clusterd. Co-Authored-By: Claude Opus 4.6 (1M context) --- src/balancerd/src/bin/balancerd.rs | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/balancerd/src/bin/balancerd.rs b/src/balancerd/src/bin/balancerd.rs index af4d4364ce618..28104b2e63c42 100644 --- a/src/balancerd/src/bin/balancerd.rs +++ b/src/balancerd/src/bin/balancerd.rs @@ -195,7 +195,9 @@ fn main() { let root_span = info_span!("balancer"); let res = match args.command { - Command::Service(args) => runtime.block_on(run(args, tracing_handle).instrument(root_span)), + Command::Service(args) => { + runtime.block_on(run(args, tracing_handle, metrics_registry).instrument(root_span)) + } }; if let Err(err) = res { @@ -203,8 +205,11 @@ fn main() { } } -pub async fn run(args: ServiceArgs, tracing_handle: TracingHandle) -> Result<(), anyhow::Error> { - let metrics_registry = MetricsRegistry::new(); +pub async fn run( + args: ServiceArgs, + tracing_handle: TracingHandle, + metrics_registry: MetricsRegistry, +) -> Result<(), anyhow::Error> { let (resolver, cancellation_resolver) = match ( args.static_resolver_addr, args.frontegg_resolver_template,