From 5496981c30ea6209354d9fcf6e990cd75e04c38d Mon Sep 17 00:00:00 2001 From: Dennis Felsing Date: Thu, 7 May 2026 04:42:25 +0000 Subject: [PATCH] persist: add missing variants to BatchColumnarFormat Arbitrary impl The proptest Arbitrary impl for BatchColumnarFormat only generated Row, Both(0), and Both(1), missing Both(2) (the production default) and Structured. This meant proptest round-trip tests for HollowBatchPart never exercised the formats actually used in production. Co-Authored-By: Claude Opus 4.6 (1M context) --- src/persist/src/indexed/encoding.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/persist/src/indexed/encoding.rs b/src/persist/src/indexed/encoding.rs index 5227aa6044005..e98255b3042dd 100644 --- a/src/persist/src/indexed/encoding.rs +++ b/src/persist/src/indexed/encoding.rs @@ -132,6 +132,8 @@ impl Arbitrary for BatchColumnarFormat { Just(BatchColumnarFormat::Row).boxed(), Just(BatchColumnarFormat::Both(0)).boxed(), Just(BatchColumnarFormat::Both(1)).boxed(), + Just(BatchColumnarFormat::Both(2)).boxed(), + Just(BatchColumnarFormat::Structured).boxed(), ]) .boxed() }