draft: add browser revive services menu#448
Draft
AlexTzib wants to merge 1 commit into
Draft
Conversation
Owner
|
Perhaps we could do as we do when we attack someone? Give the page title frame a noticeable colour (in case they use the dialog browser style, if I recall correctly, it's a word just below the CLOSE button)... and then have a button for this where the "REQUEST ASSISTANCE" (o similar) button is now? I'm just trying to avoid filling the app bar too much, as in certain pages it's already at the limit! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR for #90 so we can discuss the direction before polishing this further.
Hi @Manuito83, I wanted to check whether this matches what you had in mind for adding revive services to the browser.
What this draft tries:
Why this approach:
I avoided injecting buttons into Torn's hospital/profile DOM because that would be more fragile. This keeps the feature inside Torn PDA's browser chrome and reuses the revive flows that already work from Profile/War.
Questions before this becomes a normal PR:
Local verification:
I could not run Flutter analyzer/build locally because flutter is not available on this PATH, so CI is the compile check.