v4.2 Bad error reporting

[RoYoMi]

Problem

For those of us using the Configmgr Task Sequence Monitor we'd appreciate a better script termination reporting on failures.

For example this is what we see in when the script fails. The message reads InnerTerminatingFailure. The problem is that every single error will report this same message. This requires the user to then crack open the ApplyDriversPackage.log to see exactly what happened.

Recommendation

We'd rather see a descriptive message like this - Validation failed with empty list of matched driver packages for 'ThinkPad X1 Yoga 2nd', script execution will be terminated instead of the meaningless InnerTerminatingFailure .
With this type of message we could immediately start reviewing the root cause.

Solution

In theory this could be accomplished by make the following changes every where you're calling New-TerminatingErrorRecord

[TANielsen]

Yea, I hate seeing red in my smsts.log

[RoYoMi]

No doubt the red is bad, but I hate when the logs lack the necessary details to investigate a problem. There should be a happy compromise in how the script writes these logs.

[stephannn]

Good call. I added it to our version: #226