Possible bug when handling durations

[why-el]

The provided matcher does not work when used with durations, such as 1.day. I even tried it with the original blog post code examples [1], and it failed there as well. Digging a little deeper, I noticed a particular call duration.to_i which casts the duration to seconds and then the subsequent filtering of the jobs returns an empty array.

          duration_to_fetch = if duration.is_a?(String) || duration.is_a?(Symbol)
                                duration
                              else
                                duration
                              end

In my opinion one would not need this casting. Simply assume the duration in the code and the specs is the same.

[1] https://devpost.com/software/shoulda-matchers-for-whenever

[MGerrior]

Hey @why-el , thanks for opening this issue. Would you please be able to provide an example spec that is failing for you so that I could debug this further? I'm using the gem for the following test case and have passing tests:

# config/schedule.rb
every 1.day, at: '3:06 am' do
  rake 'locations:sweep'
end

# spec/whenever_spec.rb
describe Whenever do
  include Shoulda::Whenever

  let(:whenever) { Whenever::JobList.new(file: Rails.root.join("config", "schedule.rb").to_s) }

  it "schedules the locations sweep" do
    expect(whenever).to schedule_rake("locations:sweep").every(1.day).at("3:06 am")
  end
end

I haven't been particularly active in updating the gem, so perhaps a newer version of rspec/whenever/rails is causing an issue?

[why-el]

Hey @MGerrior, thanks for the quick response. I tried it again with the same example you provided, it failed for me. Here is a screenshot.

The 86400 is not a key in the jobs hash, so filtering is invalidated.

Here is everything Rails, Rspec and whenever related in my gem:

[MGerrior]

Thanks for providing that list. It looks like we have quite a few discrepancies, the project I originally built this gem for is still using Rails 4, along with whenever 0.9.4 and rspec 3.2.0. Looks like it may be related to this commit introduced in the 0.9.5 version of the whenever (when using Ruby 2.3).

I'll see if I can get a fix working this week for newer versions of whenever, though feel free to open a PR if you beat me to it.