Skip to content

All-File Validation for Toolchain #1529

@danieljvickers

Description

@danieljvickers

Problem it solves

When one runs the precheck command in the toolchain, one of the steps runs validate on all examples and reports the number of examples that fail, but not which examples. This requires the used to check cases one-at-a-time manually. One can accomplish this with BASH commands, but it would be much nicer if the validator had something like an --all flag and just tries to validate all examples.

Proposed solution

  1. Add an --all flag to validator that checks all examples.
  2. The flag should accurately report which cases fail validation
  3. the precheck for commits should swap from what it uses now and instead use this command
  4. (Optional) Validation is also very slow, which leads me to always commit with --no-verify. It would be nice if it were much faster.

Alternatives

You could also simply let the validate command accept wildcard values, like *, or directories and the user could simply pass in something like ./mfc.sh validate examples or ./mfc.sh validate examples/* to accomplish the same thing. But this is likely much harder to code this than the --all flag.

Metadata

Metadata

Assignees

No one assigned
    No fields configured for Feature.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions