Windows installer is not suitable for scripted installs / uninstalls . . .

[mwinkel-dev]

Affiliation
TAE Technologies (PSFC submitted on behalf of @mrclary)

Version(s) Affected
All versions

Platform(s)
Windows

Installation Method(s)
Using the *.exe installer

Describe the bug
For scripted installs of MDSplus on Windows systems, it is useful to run the installer from a shell in silent mode and optionally with a specified user directory. For example . . .

MDSplus-alpha-7.160-0-x64.exe /S /D=C:\Users\rclary\MDSplus

Although the Nullsoft installer does support the /D directory flag, the *.nsi file is ignoring it and instead installing MDSplus for all users of a system.

Furthermore, when uninstalling MDSplus, the installer is not deleting all MDSplus files from the Windows system. (It is likely just removing it from the Windows registry.)

To Reproduce

• Open a CMD or PowerShell window and then run the installer *.exe with the /D option and appropriate user directory.
• Note that MDSplus is installed (with default settings) to the Program Files\MDSplus directory and not to the specified user's directory.
• Then uninstall MDSplus and note that the files remain in Program Files\MDSplus.

Expected behavior
The /D flag should be supported, plus uninstall should delete the files.

Screenshots
n/a

Additional context
n/a

[mwinkel-dev]

Although /D is described in the Nullsoft documentation, it appears that the Function Init of the *.nsi file is ignoring it.

Current conjecture is that the initial value for $INSTDIR probably is being set to the directory specified by the /D flag. However, the Init function then might be setting $INSTDIR to the value of the MDSPLUS_DIR environment variable, which would be undefined on an initial install. Thus, the installer would default to installing for all users.

[mrclary]

@mwinkel-dev, thanks for opening the issue. Description is perfect.

[mwinkel-dev]

Hi @mrclary -- You're welcome. We'll release the PR #3061 for your previous Issue #3059, and then work on fixing this issue.

[mwinkel-dev]

Hi @mrclary,

It is now proven that the installer does receive the /D directory but overwrites it, thus silent installs are for all users.

Another obstacle for scripted installs / uninstalls is the Windows "User Account Control". However, if CMD or PowerShell is run with administrative privileges, the UAC dialog does not appear during the silent install. (But the dialog does appear when launching either shell in administrator mode.)

It will take a few days to enhance the installer so that it can be used for scripted installs / uninstalls.

[mrclary]

It is now proven that the installer does receive the /D directory but overwrites it, thus silent installs are for all users.

👍🏼

Another obstacle for scripted installs / uninstalls is the Windows "User Account Control". However, if CMD or PowerShell is run with administrative privileges, the UAC dialog does not appear during the silent install. (But the dialog does appear when launching either shell in administrator mode.)

Perfect. My particular use case does not require un-attended installation, so UAC prompts are expected. I just need the actual installer to run without requiring the user to click through all the GUI screens.

It will take a few days to enhance the installer so that it can be used for scripted installs / uninstalls.

No rush. Thanks for working on this!

[mwinkel-dev]

Hi @mrclary,

Much to my surprise, the existing installer has an undocumented feature for doing silent installs. Please give this a try and see if it is suitable for your use case.

<Installer> /S /CurrentUser
<Installer> /S /AllUsers

Where <Installer> is the name of the MDSplus installer (i.e., the *.exe file).

• The /CurrentUser option uses this installation directory: C:\Users\<username>\MDSplus.
• Note that /AllUsers is optional; its use merely adds clarity to scripts. (Omitting it causes the installer to default to all users anyway.)
• Also note that the /D=<dir> option cannot be used. Its presence causes the installation to be for all users.

After installing, log off and then log in so that the new environment variables take effect.

Also, when experimenting with repeated installations, it is always wise to start with a clean slate:

• uninstall MDSplus,
• check the environment variables (user and system) and remove entries related to MDSplus (including in the PATH),
• delete the MDSplus directory, and
• log out / log in (or restart)

Uninstall still needs to be fixed; it does not delete the MDSplus directory. Furthermore, when uninstalling for all users, it is leaving MDSplus in the system PATH environment variable.

[mrclary]

I've confirmed that /CurrentUser does result in current user install, thanks!

[mwinkel-dev]

Hi @mrclary -- Thanks for confirming that /CurrentUser is suitable for your use case. I'll investigate the uninstall glitches today so that we can release a fix next week.

[mwinkel-dev]

The root cause of the uninstall glitch is that the recycle.nsh script no longer works. It is failing on Win11 with installs on NTFS and FAT32 volumes (thus likely isn't a Unicode problem). Even though the correct absolute file path is being passed to the script, the error code indicates that it can't find the MDSplus directory. The script is using an old Win32 system call; perhaps the call is no longer compatible with recent 64-bit Windows versions.

There is now a prototype fix that uses a simpler technique to delete the MDSplus directory. It also removes MDSplus\bin from the system PATH environment variable.