feat: add kill timeout

Author: HitkoDev

README.md

@@ -51,6 +51,7 @@ There are a couple of command-line options that can be used to control which fil
 -   `--poll` - Force polling for file changes (Caution! CPU-heavy!)
 -   `--respawn` - Keep watching for changes after the script has exited
 -   `--timestamp` - The timestamp format to use for logging restarts
+-   `--kill_timeout` - Time in milliseconds to wait before force killing a stuck child process on reload
 -   `--vm` - Load files using Node's VM
 
 ### Passing arguments to node

src/cfg.cts

@@ -21,6 +21,7 @@ const defaultConfig: Options = {
     poll: false,
     respawn: false,
     timestamp: 'HH:MM:ss',
+    kill_timeout: undefined,
     vm: true
 }
 

src/cli.ts

@@ -14,7 +14,7 @@ const nodeCustom = ['inspect', 'inspect-brk', 'no-warnings']
 const nodeString = ['require']
 
 const nodeDevBoolean = ['clear', 'dedupe', 'fork', 'notify', 'poll', 'respawn', 'vm']
-const nodeDevNumber = ['debounce', 'deps', 'interval']
+const nodeDevNumber = ['debounce', 'deps', 'interval', 'kill_timeout']
 const nodeDevString = ['graceful_ipc', 'ignore', 'timestamp']
 
 const alias = { ...nodeAlias }
@@ -70,6 +70,7 @@ export interface Options {
     ignore: string[]
     interval: number
     timestamp: string
+    kill_timeout?: number
 }
 
 export const cli = (argv: string[]) => {

src/index.ts

@@ -1,6 +1,7 @@
 import { ChildProcess, fork } from 'node:child_process'
 import { join } from 'node:path'
 import { pathToFileURL } from 'node:url'
+import { clearTimeout } from 'node:timers'
 import semver from 'semver'
 import { clearFactory } from './clear.cjs'
 import { Options } from './cli.js'
@@ -23,7 +24,8 @@ export const dev = (script: string, scriptArgs: string[], nodeArgs: string[], {
     notify: notifyEnabled,
     poll: forcePolling,
     respawn,
-    timestamp
+    timestamp,
+    kill_timeout: killTimeout
 }: Options) => {
     if (!script) {
         console.log('Usage: node-dev [options] script [arguments]\n')
@@ -55,6 +57,7 @@ export const dev = (script: string, scriptArgs: string[], nodeArgs: string[], {
 
     const watcher = new FileWatcher({ debounce, forcePolling, interval })
     let isPaused = false
+    let killTimer: NodeJS.Timeout | undefined
 
     // The child_process
     let child: (ChildProcess & { respawn?: boolean }) | undefined
@@ -87,6 +90,8 @@ export const dev = (script: string, scriptArgs: string[], nodeArgs: string[], {
      */
     function start() {
         isPaused = false
+        if (killTimer)
+            clearTimeout(killTimer)
 
         const args = nodeArgs.slice()
 
@@ -128,6 +133,12 @@ export const dev = (script: string, scriptArgs: string[], nodeArgs: string[], {
     function stop(willTerminate?: boolean) {
         child!.respawn = true
         if (!willTerminate) {
+            if (typeof killTimeout === 'number') {
+                killTimer = setTimeout(() => {
+                    log.warn('Sending SIGKILL after timeout (%s ms)', killTimeout)
+                    child?.kill('SIGKILL')
+                }, killTimeout)
+            }
             if (gracefulIPC) {
                 log.info('Sending IPC: ' + JSON.stringify(gracefulIPC))
                 child!.send(gracefulIPC)