From 8ca86ee01f2f6acf7afedd65f460c322ffb9efda Mon Sep 17 00:00:00 2001 From: Fauzan Naufan Date: Mon, 28 Sep 2026 17:19:20 +0800 Subject: [PATCH 1/3] [MOL-22399][FN] fix menu section style --- src/menu/menu-section.styles.ts | 2 ++ src/menu/menu-section.tsx | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/menu/menu-section.styles.ts b/src/menu/menu-section.styles.ts index 047730ccd..6de99347a 100644 --- a/src/menu/menu-section.styles.ts +++ b/src/menu/menu-section.styles.ts @@ -14,6 +14,8 @@ export const GRID_COLUMN_GAP_PX = 8; export const section = css` padding: ${Spacing["spacing-8"]} 0; margin: 0; +`; +export const items = css` list-style: none; `; export const sectionWithDivider = css` diff --git a/src/menu/menu-section.tsx b/src/menu/menu-section.tsx index 5e96f71a6..349dc7e9c 100644 --- a/src/menu/menu-section.tsx +++ b/src/menu/menu-section.tsx @@ -65,7 +65,7 @@ export const MenuSection = ({ ref={ulRef} data-testid={testId} aria-labelledby={internalId} - className={clsx(columns && styles.columns)} + className={clsx(styles.items, columns && styles.columns)} {...otherProps} > {children} From afd2752738eba271ee2a3a3de89e62296f581b30 Mon Sep 17 00:00:00 2001 From: Fauzan Naufan Date: Tue, 29 Sep 2026 10:30:09 +0800 Subject: [PATCH 2/3] [MOL-22399][FN] address PR comments --- src/menu/menu-section.styles.ts | 10 ++++++---- src/menu/menu-section.tsx | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/menu/menu-section.styles.ts b/src/menu/menu-section.styles.ts index 6de99347a..5b8529313 100644 --- a/src/menu/menu-section.styles.ts +++ b/src/menu/menu-section.styles.ts @@ -15,9 +15,7 @@ export const section = css` padding: ${Spacing["spacing-8"]} 0; margin: 0; `; -export const items = css` - list-style: none; -`; + export const sectionWithDivider = css` border-top: ${Border["width-010"]} ${Border["solid"]} ${Colour["border"]}; `; @@ -27,7 +25,7 @@ export const label = css` color: ${Colour["text-subtler"]}; `; -export const columns = css` +export const listColumns = css` ${gridTokens.rows}: initial; display: grid; @@ -41,3 +39,7 @@ export const columns = css` grid-auto-flow: row; } `; + +export const list = css` + list-style: none; +`; diff --git a/src/menu/menu-section.tsx b/src/menu/menu-section.tsx index 349dc7e9c..9fb16eea8 100644 --- a/src/menu/menu-section.tsx +++ b/src/menu/menu-section.tsx @@ -65,7 +65,7 @@ export const MenuSection = ({ ref={ulRef} data-testid={testId} aria-labelledby={internalId} - className={clsx(styles.items, columns && styles.columns)} + className={clsx(styles.list, columns && styles.listColumns)} {...otherProps} > {children} From 09e9e9c814caf37807f19002a26e4c1c865b3216 Mon Sep 17 00:00:00 2001 From: qroll Date: Tue, 29 Sep 2026 11:07:49 +0800 Subject: [PATCH 3/3] [MOL-22399][RL] Reorder styles --- src/menu/menu-section.styles.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/menu/menu-section.styles.ts b/src/menu/menu-section.styles.ts index 5b8529313..6d10f03d4 100644 --- a/src/menu/menu-section.styles.ts +++ b/src/menu/menu-section.styles.ts @@ -25,6 +25,10 @@ export const label = css` color: ${Colour["text-subtler"]}; `; +export const list = css` + list-style: none; +`; + export const listColumns = css` ${gridTokens.rows}: initial; @@ -39,7 +43,3 @@ export const listColumns = css` grid-auto-flow: row; } `; - -export const list = css` - list-style: none; -`;