From 7d1259b46ae4f8e85f41025b49861e9f0793d147 Mon Sep 17 00:00:00 2001 From: Jonas Ha Date: Sun, 21 Dec 2025 13:04:58 -0500 Subject: [PATCH 1/4] chore(settings): disable namespace check highlighting in inspection rules - Updated MinimalLambda.sln.DotSettings to set CheckNamespace inspection severity to DO_NOT_SHOW. --- MinimalLambda.sln.DotSettings | 1 + 1 file changed, 1 insertion(+) diff --git a/MinimalLambda.sln.DotSettings b/MinimalLambda.sln.DotSettings index e8728508..7497ea41 100644 --- a/MinimalLambda.sln.DotSettings +++ b/MinimalLambda.sln.DotSettings @@ -1,4 +1,5 @@  + DO_NOT_SHOW <?xml version="1.0" encoding="utf-16"?><Profile name="Full Custom Cleanup"><CppReformatCode>True</CppReformatCode><FSharpReformatCode>True</FSharpReformatCode><ShaderLabReformatCode>True</ShaderLabReformatCode><XMLReformatCode>True</XMLReformatCode><VBReformatCode>True</VBReformatCode><CSReformatCode>True</CSReformatCode><CSharpReformatComments>True</CSharpReformatComments><CSCodeStyleAttributes ArrangeVarStyle="True" ArrangeTypeAccessModifier="True" ArrangeTypeMemberAccessModifier="True" SortModifiers="True" ArrangeArgumentsStyle="True" RemoveRedundantParentheses="True" AddMissingParentheses="True" ArrangeBraces="True" ArrangeAttributes="True" ArrangeCodeBodyStyle="True" ArrangeTrailingCommas="True" ArrangeObjectCreation="True" ArrangeDefaultValue="True" ArrangeNamespaces="True" ArrangeNullCheckingPattern="True" /><CSArrangeQualifiers>True</CSArrangeQualifiers><CSFixBuiltinTypeReferences>True</CSFixBuiltinTypeReferences><CppCodeStyleCleanupDescriptor ArrangeBraces="True" ArrangeAuto="True" ArrangeFunctionDeclarations="True" ArrangeNestedNamespaces="True" ArrangeTypeAliases="True" ArrangeCVQualifiers="True" ArrangeSlashesInIncludeDirectives="True" ArrangeOverridingFunctions="True" SortDefinitions="True" SortIncludeDirectives="True" SortMemberInitializers="True" /><FormatAttributeQuoteDescriptor>True</FormatAttributeQuoteDescriptor><CSOptimizeUsings><OptimizeUsings>True</OptimizeUsings></CSOptimizeUsings><CSShortenReferences>True</CSShortenReferences><VBOptimizeImports>True</VBOptimizeImports><VBShortenReferences>True</VBShortenReferences><Xaml.RemoveRedundantNamespaceAlias>True</Xaml.RemoveRedundantNamespaceAlias><AspOptimizeRegisterDirectives>True</AspOptimizeRegisterDirectives><CSReorderTypeMembers>True</CSReorderTypeMembers><RemoveCodeRedundancies>True</RemoveCodeRedundancies><CSUseAutoProperty>True</CSUseAutoProperty><CSMakeFieldReadonly>True</CSMakeFieldReadonly><CSMakeAutoPropertyGetOnly>True</CSMakeAutoPropertyGetOnly><CppAddTypenameTemplateKeywords>True</CppAddTypenameTemplateKeywords><CppCStyleToStaticCastDescriptor>True</CppCStyleToStaticCastDescriptor><CppRedundantDereferences>True</CppRedundantDereferences><CppDeleteRedundantAccessSpecifier>True</CppDeleteRedundantAccessSpecifier><CppRemoveCastDescriptor>True</CppRemoveCastDescriptor><CppRemoveElseKeyword>True</CppRemoveElseKeyword><CppShortenQualifiedName>True</CppShortenQualifiedName><CppDeleteRedundantSpecifier>True</CppDeleteRedundantSpecifier><CppRemoveStatement>True</CppRemoveStatement><CppDeleteRedundantTypenameTemplateKeywords>True</CppDeleteRedundantTypenameTemplateKeywords><CppReplaceExpressionWithBooleanConst>True</CppReplaceExpressionWithBooleanConst><CppMakeIfConstexpr>True</CppMakeIfConstexpr><CppMakePostfixOperatorPrefix>True</CppMakePostfixOperatorPrefix><CppMakeVariableConstexpr>True</CppMakeVariableConstexpr><CppChangeSmartPointerToMakeFunction>True</CppChangeSmartPointerToMakeFunction><CppReplaceThrowWithRethrowFix>True</CppReplaceThrowWithRethrowFix><CppTypeTraitAliasDescriptor>True</CppTypeTraitAliasDescriptor><CppRemoveRedundantConditionalExpressionDescriptor>True</CppRemoveRedundantConditionalExpressionDescriptor><CppSimplifyConditionalExpressionDescriptor>True</CppSimplifyConditionalExpressionDescriptor><CppReplaceExpressionWithNullptr>True</CppReplaceExpressionWithNullptr><CppReplaceTieWithStructuredBindingDescriptor>True</CppReplaceTieWithStructuredBindingDescriptor><CppUseAssociativeContainsDescriptor>True</CppUseAssociativeContainsDescriptor><CppUseEraseAlgorithmDescriptor>True</CppUseEraseAlgorithmDescriptor><CppJoinDeclarationAndAssignmentDescriptor>True</CppJoinDeclarationAndAssignmentDescriptor><CppMakeClassFinal>True</CppMakeClassFinal><CppMakeLocalVarConstDescriptor>True</CppMakeLocalVarConstDescriptor><CppMakeMethodConst>True</CppMakeMethodConst><CppMakeMethodStatic>True</CppMakeMethodStatic><CppMakePtrOrRefParameterConst>True</CppMakePtrOrRefParameterConst><CppMakeParameterConst>True</CppMakeParameterConst><CppPassValueParameterByConstReference>True</CppPassValueParameterByConstReference><CppRemoveElaboratedTypeSpecifierDescriptor>True</CppRemoveElaboratedTypeSpecifierDescriptor><CppRemoveRedundantLambdaParameterListDescriptor>True</CppRemoveRedundantLambdaParameterListDescriptor><CppRemoveRedundantMemberInitializerDescriptor>True</CppRemoveRedundantMemberInitializerDescriptor><CppRemoveRedundantParentheses>True</CppRemoveRedundantParentheses><CppRemoveTemplateArgumentsDescriptor>True</CppRemoveTemplateArgumentsDescriptor><CppRemoveUnreachableCode>True</CppRemoveUnreachableCode><CppRemoveUnusedIncludes>True</CppRemoveUnusedIncludes><CppRemoveUnusedLambdaCaptures>True</CppRemoveUnusedLambdaCaptures><CppReplaceIfWithIfConsteval>True</CppReplaceIfWithIfConsteval><RemoveCodeRedundanciesVB>True</RemoveCodeRedundanciesVB><VBMakeFieldReadonly>True</VBMakeFieldReadonly><Xaml.RedundantFreezeAttribute>True</Xaml.RedundantFreezeAttribute><Xaml.RemoveRedundantModifiersAttribute>True</Xaml.RemoveRedundantModifiersAttribute><Xaml.RemoveRedundantNameAttribute>True</Xaml.RemoveRedundantNameAttribute><Xaml.RemoveRedundantResource>True</Xaml.RemoveRedundantResource><Xaml.RemoveRedundantCollectionProperty>True</Xaml.RemoveRedundantCollectionProperty><Xaml.RemoveRedundantAttachedPropertySetter>True</Xaml.RemoveRedundantAttachedPropertySetter><Xaml.RemoveRedundantStyledValue>True</Xaml.RemoveRedundantStyledValue><Xaml.RemoveForbiddenResourceName>True</Xaml.RemoveForbiddenResourceName><Xaml.RemoveRedundantGridDefinitionsAttribute>True</Xaml.RemoveRedundantGridDefinitionsAttribute><Xaml.RemoveRedundantUpdateSourceTriggerAttribute>True</Xaml.RemoveRedundantUpdateSourceTriggerAttribute><Xaml.RemoveRedundantBindingModeAttribute>True</Xaml.RemoveRedundantBindingModeAttribute><Xaml.RemoveRedundantGridSpanAttribut>True</Xaml.RemoveRedundantGridSpanAttribut><IDEA_SETTINGS>&lt;profile version="1.0"&gt; &lt;option name="myName" value="Full Custom Cleanup" /&gt; &lt;inspection_tool class="ConditionalExpressionWithIdenticalBranchesJS" enabled="true" level="WARNING" enabled_by_default="true" /&gt; From 92c78bbe969b37df679ecf03da6b3e54ff0a3781 Mon Sep 17 00:00:00 2001 From: Jonas Ha Date: Sun, 21 Dec 2025 13:08:29 -0500 Subject: [PATCH 2/4] chore(project): migrate `InternalsVisibleTo` declarations to project files - Removed `InternalsVisibleTo` attributes from AssemblyInfo.cs files. - Added `InternalsVisibleTo` declarations directly to project files across all relevant projects. --- .../MinimalLambda.SourceGenerators.csproj | 4 ++++ src/MinimalLambda.SourceGenerators/Properties/AssemblyInfo.cs | 4 ---- src/MinimalLambda.Testing/MinimalLambda.Testing.csproj | 3 +++ src/MinimalLambda.Testing/Properties/AssemblyInfo.cs | 3 --- src/MinimalLambda/MinimalLambda.csproj | 4 ++++ src/MinimalLambda/Properties/AssemblyInfo.cs | 4 ---- .../MinimalLambda.Testing.UnitTests.DiLambda.csproj | 4 ++++ .../Properties/AssemblyInfo.cs | 4 ---- .../MinimalLambda.Testing.UnitTests.NoEventLambda.csproj | 3 +++ .../Properties/AssemblyInfo.cs | 3 --- .../MinimalLambda.Testing.UnitTests.NoResponseLambda.csproj | 3 +++ .../Properties/AssemblyInfo.cs | 3 --- .../MinimalLambda.Testing.UnitTests.SimpleLambda.csproj | 3 +++ .../Properties/AssemblyInfo.cs | 3 --- 14 files changed, 24 insertions(+), 24 deletions(-) delete mode 100644 src/MinimalLambda.SourceGenerators/Properties/AssemblyInfo.cs delete mode 100644 src/MinimalLambda.Testing/Properties/AssemblyInfo.cs delete mode 100644 src/MinimalLambda/Properties/AssemblyInfo.cs delete mode 100644 tests/MinimalLambda.Testing.UnitTests/Lambdas/MinimalLambda.Testing.UnitTests.DiLambda/Properties/AssemblyInfo.cs delete mode 100644 tests/MinimalLambda.Testing.UnitTests/Lambdas/MinimalLambda.Testing.UnitTests.NoEventLambda/Properties/AssemblyInfo.cs delete mode 100644 tests/MinimalLambda.Testing.UnitTests/Lambdas/MinimalLambda.Testing.UnitTests.NoResponseLambda/Properties/AssemblyInfo.cs delete mode 100644 tests/MinimalLambda.Testing.UnitTests/Lambdas/MinimalLambda.Testing.UnitTests.SimpleLambda/Properties/AssemblyInfo.cs diff --git a/src/MinimalLambda.SourceGenerators/MinimalLambda.SourceGenerators.csproj b/src/MinimalLambda.SourceGenerators/MinimalLambda.SourceGenerators.csproj index fb677672..7ab38e5e 100644 --- a/src/MinimalLambda.SourceGenerators/MinimalLambda.SourceGenerators.csproj +++ b/src/MinimalLambda.SourceGenerators/MinimalLambda.SourceGenerators.csproj @@ -10,6 +10,10 @@ false false + + + + all diff --git a/src/MinimalLambda.SourceGenerators/Properties/AssemblyInfo.cs b/src/MinimalLambda.SourceGenerators/Properties/AssemblyInfo.cs deleted file mode 100644 index e6be45eb..00000000 --- a/src/MinimalLambda.SourceGenerators/Properties/AssemblyInfo.cs +++ /dev/null @@ -1,4 +0,0 @@ -using System.Runtime.CompilerServices; - -[assembly: InternalsVisibleTo("MinimalLambda.SourceGenerators.UnitTests")] -[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")] diff --git a/src/MinimalLambda.Testing/MinimalLambda.Testing.csproj b/src/MinimalLambda.Testing/MinimalLambda.Testing.csproj index 90a3e785..89be6c1b 100644 --- a/src/MinimalLambda.Testing/MinimalLambda.Testing.csproj +++ b/src/MinimalLambda.Testing/MinimalLambda.Testing.csproj @@ -12,6 +12,9 @@ In-memory testing harness for MinimalLambda README.md + + + diff --git a/src/MinimalLambda.Testing/Properties/AssemblyInfo.cs b/src/MinimalLambda.Testing/Properties/AssemblyInfo.cs deleted file mode 100644 index e3d42db9..00000000 --- a/src/MinimalLambda.Testing/Properties/AssemblyInfo.cs +++ /dev/null @@ -1,3 +0,0 @@ -using System.Runtime.CompilerServices; - -[assembly: InternalsVisibleTo("MinimalLambda.Testing.UnitTests")] diff --git a/src/MinimalLambda/MinimalLambda.csproj b/src/MinimalLambda/MinimalLambda.csproj index 8e40ee54..2c210d35 100644 --- a/src/MinimalLambda/MinimalLambda.csproj +++ b/src/MinimalLambda/MinimalLambda.csproj @@ -13,6 +13,10 @@ README.md $(InterceptorsNamespaces);MinimalLambda.Generated + + + + diff --git a/src/MinimalLambda/Properties/AssemblyInfo.cs b/src/MinimalLambda/Properties/AssemblyInfo.cs deleted file mode 100644 index e4318b15..00000000 --- a/src/MinimalLambda/Properties/AssemblyInfo.cs +++ /dev/null @@ -1,4 +0,0 @@ -using System.Runtime.CompilerServices; - -[assembly: InternalsVisibleTo("MinimalLambda.UnitTests")] -[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")] diff --git a/tests/MinimalLambda.Testing.UnitTests/Lambdas/MinimalLambda.Testing.UnitTests.DiLambda/MinimalLambda.Testing.UnitTests.DiLambda.csproj b/tests/MinimalLambda.Testing.UnitTests/Lambdas/MinimalLambda.Testing.UnitTests.DiLambda/MinimalLambda.Testing.UnitTests.DiLambda.csproj index e26f02d7..303b8b03 100644 --- a/tests/MinimalLambda.Testing.UnitTests/Lambdas/MinimalLambda.Testing.UnitTests.DiLambda/MinimalLambda.Testing.UnitTests.DiLambda.csproj +++ b/tests/MinimalLambda.Testing.UnitTests/Lambdas/MinimalLambda.Testing.UnitTests.DiLambda/MinimalLambda.Testing.UnitTests.DiLambda.csproj @@ -12,6 +12,10 @@ $(InterceptorsNamespaces);MinimalLambda.Generated false + + + + $(InterceptorsNamespaces);MinimalLambda.Generated false + + + $(InterceptorsNamespaces);MinimalLambda.Generated false + + + $(InterceptorsNamespaces);MinimalLambda.Generated false + + + Date: Sun, 21 Dec 2025 13:10:45 -0500 Subject: [PATCH 3/4] docs(commands): clarify valid values for PR title format - Updated descriptions for `` and `` to specify "Valid values are" for clarity. --- .claude/commands/pr.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.claude/commands/pr.md b/.claude/commands/pr.md index 721b539d..2d624368 100644 --- a/.claude/commands/pr.md +++ b/.claude/commands/pr.md @@ -1,7 +1,7 @@ # Open PR for current branch - $ARGUMENTS - PR title must follow the format: `(): ` - - Valid ``: + - Valid values for `` are: - feat - fix - docs @@ -9,7 +9,7 @@ - test - chore - ci - - Valid ``: + - Valid values for `` are: - host - envelopes - abstractions From b319bca2ddfafb0cc21af98e540f9dd7eaf51260 Mon Sep 17 00:00:00 2001 From: Jonas Ha Date: Sun, 21 Dec 2025 13:11:32 -0500 Subject: [PATCH 4/4] docs(commands): clarify `` as optional in PR title format - Updated the description to indicate that `` is optional. --- .claude/commands/pr.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.claude/commands/pr.md b/.claude/commands/pr.md index 2d624368..a7c7f654 100644 --- a/.claude/commands/pr.md +++ b/.claude/commands/pr.md @@ -9,7 +9,7 @@ - test - chore - ci - - Valid values for `` are: + - `` is optional. Valid values for `` are: - host - envelopes - abstractions