[Contracts] LoanManager refinance_loan returns InsufficientScore for an insufficient-collateral condition

[grantfox-oss]

Telegram (ask questions / claim the issue here first): https://t.me/+DOylgFv1jyJlNzM0

Why this matters

In loan_manager/src/lib.rs refinance_loan, the check if loan.collateral_amount < new_amount { return Err(LoanError::InsufficientScore); } returns the wrong error variant. A dedicated InsufficientCollateral = 26 variant already exists in the LoanError enum but is unused here, so callers receive a misleading error and cannot distinguish a credit-score failure from a collateral shortfall.

Acceptance criteria

• Return LoanError::InsufficientCollateral for the collateral coverage check in refinance_loan
• Audit other LoanError returns for similarly misused variants
• Add a test asserting refinance with insufficient collateral returns InsufficientCollateral
• Confirm InsufficientCollateral is actually exercised somewhere after the fix

Files to touch

• loan_manager/src/lib.rs

Out of scope

• Reworking refinance collateral ratio policy
• Adding new error variants

[Godbrand0]

hello, i would like to work on this issue

[Dopezapha]

Hey maintainer, I would love to work on this issue. Kindly assign me the issue. Thanks

[grantfox-oss]

🦊 GrantFox — @Godbrand0 has been assigned to this issue as part of the Official Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #6)
2. Your PR will be reviewed by the LabsCrypt maintainers

Good luck! Track your progress on GrantFox.