[Contracts] RemittanceNFT update_score has a redundant/unreachable minimum-repayment check

[grantfox-oss]

Telegram (ask questions / claim the issue here first): https://t.me/+DOylgFv1jyJlNzM0

Why this matters

In remittance_nft/src/lib.rs update_score, after repayment_amount < min_repayment returns BelowMinimum, the next check if repayment_amount < Self::MIN_SCORE_UPDATE_REPAYMENT (100) returns InvalidRepaymentAmount, and later let points_i128 = repayment_amount / 100; if points_i128 == 0 { return Ok(()) } is dead because amounts below 100 already returned. The overlapping floors are confusing and partly unreachable.

Acceptance criteria

• Consolidate the repayment-floor logic into a single clear check with one error variant
• Remove or justify the now-unreachable points_i128 == 0 early return
• Add tests for amounts at the boundaries (99, 100, below configured min) asserting the documented error
• Update the doc comment to match the final logic

Files to touch

• remittance_nft/src/lib.rs

Out of scope

• Changing the points-per-repayment formula
• Token-denomination handling

[MarcusDavidG]

I can handle this issue and will like to work on it, Please assign thank you.

[K1NGD4VID]

Hello maintainer, i would like to work on this issue

[grantfox-oss]

🦊 GrantFox — @K1NGD4VID has been assigned to this issue as part of the Official Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #13)
2. Your PR will be reviewed by the LabsCrypt maintainers

Good luck! Track your progress on GrantFox.