Skip to content

Update for standing priority #1905 #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svelderrainruiz wants to merge 1 commit into
base: issue/upstream-1905-loop-topology-runbook-feed
Choose a base branch
from
Open

Update for standing priority #1905 #1933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 53 additions & 2 deletions docs/schemas/integration-runbook-v1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,62 @@
]
},
"status": { "type": "string", "enum": ["Passed", "Failed", "Skipped"] },
"details": { "type": "object" }
"details": {
"type": "object",
"properties": {
"exitCode": { "type": ["integer", "null"] },
"error": { "type": "string" },
"loopIterations": { "type": "integer", "minimum": 0 },
"finalStatusPath": { "type": "string" },
"finalStatusReadError": { "type": "string" },
"finalStatusMissing": { "type": "boolean" },
"harness": {
"type": "object",
"properties": {
"runtimeSurface": { "const": "windows-native-teststand" },
"processModelClass": {
"type": "string",
"enum": ["sequential-process-model", "parallel-process-model"]
},
"windowsOnly": { "type": "boolean" },
"requestedSimultaneous": { "type": "boolean" },
"cellClass": { "type": ["string", "null"] },
"executionCellLeasePath": { "type": "string" },
"executionCellId": { "type": "string" },
"executionCellLeaseId": { "type": "string" },
"harnessInstanceLeasePath": { "type": "string" },
"harnessInstanceLeaseId": { "type": "string" },
"harnessInstanceId": { "type": "string" }
},
"additionalProperties": true
},
"executionTopology": {
"type": "object",
"properties": {
"runtimeSurface": { "const": "windows-native-teststand" },
"processModelClass": {
"type": "string",
"enum": ["sequential-process-model", "parallel-process-model"]
},
"windowsOnly": { "type": "boolean" },
"requestedSimultaneous": { "type": "boolean" },
"cellClass": { "type": ["string", "null"] },
"executionCellLeasePath": { "type": "string" },
"executionCellId": { "type": "string" },
"executionCellLeaseId": { "type": "string" },
"harnessInstanceLeasePath": { "type": "string" },
"harnessInstanceLeaseId": { "type": "string" },
"harnessInstanceId": { "type": "string" }
},
"additionalProperties": true
}
},
"additionalProperties": true
}
},
"additionalProperties": false
}
}
},
"additionalProperties": true
}
}
3 changes: 3 additions & 0 deletions tests/IntegrationRunbook.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Describe 'IntegrationRunbook - Phase Selection & JSON' -Tag 'Unit' {
$global:runRoot = Resolve-Path (Join-Path $PSScriptRoot '..')
$global:runScript = Resolve-Path $scriptPath
$global:schemaFile = Resolve-Path $schemaPath
. "$PSScriptRoot/TestHelpers.Schema.ps1"
}

It 'emits JSON with expected schema id and core properties (subset phases)' {
Expand All @@ -31,6 +32,7 @@ Describe 'IntegrationRunbook - Phase Selection & JSON' -Tag 'Unit' {
Test-Path $tmp | Should -BeTrue
$json = Get-Content $tmp -Raw | ConvertFrom-Json
$json.schema | Should -Be 'integration-runbook-v1'
Assert-JsonShape -Path $tmp -Spec 'IntegrationRunbook' | Should -BeTrue
$json.phases.Count | Should -Be 2
($json.phases | ForEach-Object name) | Should -Be @('Prereqs','ViInputs')
$json.overallStatus | Should -Match 'Passed|Failed'
Expand Down Expand Up @@ -166,6 +168,7 @@ exit 0

Test-Path $tmp | Should -BeTrue
$json = Get-Content $tmp -Raw | ConvertFrom-Json
Assert-JsonShape -Path $tmp -Spec 'IntegrationRunbook' | Should -BeTrue
$loopPhase = $json.phases | Where-Object name -eq 'Loop'
$loopPhase.status | Should -Be 'Passed'
$loopPhase.details.loopIterations | Should -Be 2
Expand Down
11 changes: 11 additions & 0 deletions tests/TestHelpers.Schema.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,17 @@ $script:JsonShapeSpecs['LoopEvent'] = [pscustomobject]@{
}
}

$script:JsonShapeSpecs['IntegrationRunbook'] = [pscustomobject]@{
Required = @('schema','generated','phases','overallStatus')
Optional = @()
Types = @{
schema = { param($v) $v -is [string] -and $v -eq 'integration-runbook-v1' }
generated = { param($v) ($v -is [string]) -or ($v -is [datetime]) }
overallStatus = { param($v) $v -is [string] -and $v -match '^(Passed|Failed)$' }
phases = { param($v) $v -is [object[]] }
}
}

function Assert-JsonShape {
[CmdletBinding()] param(
[Parameter(Mandatory)][string]$Path,
Expand Down
Loading