Firecrown 1.14#454
Conversation
elvinpoole
left a comment
There was a problem hiding this comment.
Firecrown edits look good, but the NERSC install has an conflict with the numcosmo_py
There was a problem hiding this comment.
I tried testing this on NERSC
Looks like firecrown switched from setup.cfg to pyproject.toml so we need to add
sed -i '/numcosmo/d' pyproject.toml
For the install
However, the test then fails due to ModuleNotFoundError: No module named 'numcosmo_py'
Seems this wasn;t a required dependancy before but now it is
see the firecrown.module.cluster init before and after here:
https://github.com/LSSTDESC/firecrown/blob/v1.7.5/firecrown/models/cluster/__init__.py
https://github.com/LSSTDESC/firecrown/blob/v1.14.0/firecrown/models/cluster/__init__.py
There was a problem hiding this comment.
Thanks! I'll try to fix by using mamba firecrown, but I now see an error with mpi, something totally different, so will need to investigate.
|
We may need to put the numcosmo dependency in the conda package |
catch up with main branch
This updates to being compatible with (and I assume) requiring FireCrown 1.14