From c05c0e6ea2be3600a474b41f3c53e4cdbd74e391 Mon Sep 17 00:00:00 2001 From: GeekMr <140129782+WilliamWang1721@users.noreply.github.com> Date: Sat, 3 Oct 2026 13:48:15 +0800 Subject: [PATCH 1/3] Add a live display-only switch for tab status badges --- nebula_app/i18n/en-US.json | 2 + nebula_app/i18n/zh-CN.json | 2 + nebula_app/src/gpui_shell/config.rs | 2 + nebula_app/src/gpui_shell/settings_pane.rs | 1 + .../settings_pane/appearance_advanced.rs | 7 ++ .../settings_pane/theme_studio_tests.rs | 28 +++++++ .../workspace/settings_navigation/ui_tests.rs | 83 +++++++++++++++++++ .../src/gpui_shell/workspace/sidebar.rs | 5 ++ .../gpui_shell/workspace/tab_presentation.rs | 14 +++- .../src/gpui_shell/workspace/top_tabs.rs | 4 + nebula_settings/src/lib.rs | 14 ++++ nebula_settings/src/reset.rs | 8 ++ 12 files changed, 168 insertions(+), 2 deletions(-) diff --git a/nebula_app/i18n/en-US.json b/nebula_app/i18n/en-US.json index 52874d55b..6fe15918f 100644 --- a/nebula_app/i18n/en-US.json +++ b/nebula_app/i18n/en-US.json @@ -17,6 +17,8 @@ "en_us": "English" }, "settings": { + "show_tab_status": "Show tab activity indicators", + "show_tab_status_description": "Show running, waiting, completion and shell status badges. Changes apply to open tabs.", "completion": { "mode": "Completion mode", "cycle": "Cycle completion mode", diff --git a/nebula_app/i18n/zh-CN.json b/nebula_app/i18n/zh-CN.json index a61a8c5b9..80e95865a 100644 --- a/nebula_app/i18n/zh-CN.json +++ b/nebula_app/i18n/zh-CN.json @@ -17,6 +17,8 @@ "en_us": "English" }, "settings": { + "show_tab_status": "显示标签活动状态", + "show_tab_status_description": "显示运行、等待、完成状态与 Shell 短标。更改会立即应用到已打开的标签。", "completion": { "mode": "补齐模式", "cycle": "切换补齐模式", diff --git a/nebula_app/src/gpui_shell/config.rs b/nebula_app/src/gpui_shell/config.rs index 7d9fa9888..8f880ea44 100644 --- a/nebula_app/src/gpui_shell/config.rs +++ b/nebula_app/src/gpui_shell/config.rs @@ -90,6 +90,7 @@ pub struct Settings { pub notification_duration: nebula_settings::NotificationDuration, /// 标签关闭按钮与标签插入动画都在渲染热路径读取,必须随全局设置驻留内存。 pub tab_close_visible: bool, + pub show_tab_status: bool, pub tab_reveal: nebula_settings::TabRevealName, /// 命令补全设置(settings.txt 的 `ghost`/`completion_style`), /// 类型直接用旧壳 display 的语义枚举:接受键判定与样式分支两壳同源。 @@ -303,6 +304,7 @@ impl Settings { ai_toasts: runtime.ai_toasts, notification_duration: runtime.notification_duration, tab_close_visible: runtime.tab_close_visible, + show_tab_status: runtime.show_tab_status, tab_reveal: runtime.tab_reveal, ghost: runtime.ghost, completion_style: runtime.completion_style, diff --git a/nebula_app/src/gpui_shell/settings_pane.rs b/nebula_app/src/gpui_shell/settings_pane.rs index fbb910dab..0bd502691 100644 --- a/nebula_app/src/gpui_shell/settings_pane.rs +++ b/nebula_app/src/gpui_shell/settings_pane.rs @@ -758,6 +758,7 @@ impl SettingsPane { "dim_inactive_panes" => flag!(dim_inactive_panes), "multiline_paste_confirm" => flag!(multiline_paste_confirm), "tab_close_visible" => flag!(tab_close_visible), + "show_tab_status" => flag!(show_tab_status), "terminal_proxy" => flag!(terminal_proxy), "refresh_environment" => flag!(refresh_environment), "powerline" => flag!(powerline), diff --git a/nebula_app/src/gpui_shell/settings_pane/appearance_advanced.rs b/nebula_app/src/gpui_shell/settings_pane/appearance_advanced.rs index fe1871d38..cbd5fa7ea 100644 --- a/nebula_app/src/gpui_shell/settings_pane/appearance_advanced.rs +++ b/nebula_app/src/gpui_shell/settings_pane/appearance_advanced.rs @@ -76,6 +76,13 @@ impl SettingsPane { self.runtime.dim_inactive_panes, cx, )) + .child(self.switch_row( + "show_tab_status", + language.text(crate::i18n::Message::SettingsShowTabStatus), + language.text(crate::i18n::Message::SettingsShowTabStatusDescription), + self.runtime.show_tab_status, + cx, + )) .child(self.switch_row( "tab_close_visible", language.pick("显示标签关闭按钮", "Show tab close buttons"), diff --git a/nebula_app/src/gpui_shell/settings_pane/theme_studio_tests.rs b/nebula_app/src/gpui_shell/settings_pane/theme_studio_tests.rs index 65cf99650..a9c8b35c9 100644 --- a/nebula_app/src/gpui_shell/settings_pane/theme_studio_tests.rs +++ b/nebula_app/src/gpui_shell/settings_pane/theme_studio_tests.rs @@ -1683,3 +1683,31 @@ fn theme_editor_save_only_forks_a_non_active_custom_template_without_publishing_ assert_eq!(settings_file_snapshot(), before_save_settings); assert_eq!(settings_file_snapshot(), before_settings_file); } + +#[gpui::test] +fn tab_status_switch_persists_and_hot_applies(cx: &mut TestAppContext) { + use crate::gpui_shell::config::Settings; + let _lock = lock_theme_studio(); + let _guard = SettingsBytesGuard::capture(); + std::fs::create_dir_all(nebula_settings::settings_dir()).unwrap(); + std::fs::write(nebula_settings::settings_path(), TEST_SETTINGS).unwrap(); + let (pane, mut window) = open_settings(cx); + window.simulate_resize(size(px(1280.0), px(1800.0))); + for expected in [false, true] { + draw(&mut window); + let bounds = window.debug_bounds("nebula-switch-show_tab_status").unwrap(); + window.simulate_event(gpui::ScrollWheelEvent { + position: gpui::point(bounds.center().x, px(900.0)), + delta: gpui::ScrollDelta::Pixels(gpui::point(px(0.0), px(900.0) - bounds.center().y)), + touch_phase: gpui::TouchPhase::Moved, + modifiers: Modifiers::default(), + }); + draw(&mut window); + click("nebula-switch-show_tab_status", &mut window); + assert_eq!(RuntimeSettings::load().show_tab_status, expected); + assert_eq!(window.read(|cx| cx.global::().show_tab_status), expected); + pane.read_with(&window, |pane, _| assert_eq!(pane.runtime.show_tab_status, expected)); + let reopened = window.update(|window, cx| cx.new(|cx| SettingsPane::new(window, cx))); + reopened.read_with(&window, |pane, _| assert_eq!(pane.runtime.show_tab_status, expected)); + } +} diff --git a/nebula_app/src/gpui_shell/workspace/settings_navigation/ui_tests.rs b/nebula_app/src/gpui_shell/workspace/settings_navigation/ui_tests.rs index e91352f66..68d931b2c 100644 --- a/nebula_app/src/gpui_shell/workspace/settings_navigation/ui_tests.rs +++ b/nebula_app/src/gpui_shell/workspace/settings_navigation/ui_tests.rs @@ -240,3 +240,86 @@ fn density_changes_real_tab_bounds_and_sidebar_drag_pitch(cx: &mut TestAppContex } } } + +#[gpui::test] +fn hiding_tab_status_keeps_hover_close_selection_keyboard_and_collapsed_title( + cx: &mut TestAppContext, +) { + use crate::gpui_shell::config::Settings; + use nebula_settings::TabsPositionName; + let (_directory, workspace, mut window) = open_workspace(2, cx); + window.update(|window, cx| { + workspace.update(cx, |workspace, cx| { + workspace.close_settings(window, cx); + workspace.active = 0; + cx.global_mut::().tab_close_visible = true; + }); + }); + for (position, row, status, close) in [ + ( + TabsPositionName::Sidebar, + "sidebar-tab-1", + "sidebar-tab-status-1", + "close-sidebar-tab-1", + ), + (TabsPositionName::Top, "top-tab-1", "top-tab-status-1", "close-top-tab-1"), + ] { + for visible in [true, false, true, false] { + window.update(|_, cx| { + workspace.update(cx, |workspace, cx| { + workspace.active = 0; + workspace.tab_meta[1].has_bell = true; + workspace.tabs_position = position; + workspace.sidebar_collapsed = false; + cx.global_mut::().show_tab_status = visible; + workspace.sync_settings_layout(false); + cx.notify(); + }); + }); + let bounds = tab_bounds(row, &mut window); + assert_eq!(window.debug_bounds(status).is_some(), visible); + workspace.read_with(&window, |workspace, cx| { + assert!( + workspace.tab_meta[1].has_bell, + "display preference does not clear observed state" + ); + assert_eq!( + workspace.tab_presentation(1, cx, true).activity, + if visible { SidebarActivity::Done } else { SidebarActivity::Idle } + ); + }); + window.simulate_mouse_move(bounds.center(), None, Modifiers::default()); + tab_bounds(row, &mut window); + assert!(window.debug_bounds(close).is_some(), "the hover close button remains laid out"); + } + click_tab(row, &mut window); + workspace.read_with(&window, |workspace, _| assert_eq!(workspace.active, 1)); + } + window.update(|window, cx| { + workspace.update(cx, |workspace, cx| { + workspace.active = 0; + workspace.tabs_position = TabsPositionName::Sidebar; + workspace.sidebar_collapsed = true; + workspace.focus_active(window, cx); + cx.notify(); + }); + }); + let title = tab_bounds("collapsed-tab-title", &mut window); + assert!(title.size.width > px(0.0)); + assert!(window.debug_bounds("sidebar-tab-1").is_none()); + window.update(|_, cx| { + workspace.update(cx, |workspace, cx| { + workspace.tabs_position = TabsPositionName::Top; + workspace.sidebar_collapsed = false; + cx.notify(); + }); + }); + tab_bounds("top-tab-1", &mut window); + window.simulate_keystrokes("ctrl-tab"); + workspace.read_with(&window, |workspace, _| assert_eq!(workspace.active, 1)); + let row = tab_bounds("top-tab-1", &mut window); + window.simulate_mouse_move(row.center(), None, Modifiers::default()); + tab_bounds("top-tab-1", &mut window); + click_tab("close-top-tab-1", &mut window); + workspace.read_with(&window, |workspace, _| assert_eq!(workspace.tabs.len(), 1)); +} diff --git a/nebula_app/src/gpui_shell/workspace/sidebar.rs b/nebula_app/src/gpui_shell/workspace/sidebar.rs index 38267f506..09941d5bf 100644 --- a/nebula_app/src/gpui_shell/workspace/sidebar.rs +++ b/nebula_app/src/gpui_shell/workspace/sidebar.rs @@ -536,6 +536,7 @@ impl NebulaWorkspace { .inset_0() .justify_end() .items_center() + .debug_selector(move || format!("sidebar-tab-status-{ix}")) .group_hover(hover_group.clone(), |item| item.invisible()) .child(status), ) @@ -553,6 +554,9 @@ impl NebulaWorkspace { .when(tab_close_visible, |slot| { slot.child( Button::new(("close-tab", ix)) + .debug_selector(move || { + format!("close-sidebar-tab-{ix}") + }) .icon(IconName::Close) .ghost() .xsmall() @@ -1002,6 +1006,7 @@ impl NebulaWorkspace { .text_size(px(label_px)) .font_weight(FontWeight::NORMAL) .text_color(ink) + .debug_selector(|| "collapsed-tab-title".into()) .child(title), ) // 折叠态没有侧栏行可看,分屏数量只能挂在这里;> 1 才画。 diff --git a/nebula_app/src/gpui_shell/workspace/tab_presentation.rs b/nebula_app/src/gpui_shell/workspace/tab_presentation.rs index 0f6d6dc22..4475a2957 100644 --- a/nebula_app/src/gpui_shell/workspace/tab_presentation.rs +++ b/nebula_app/src/gpui_shell/workspace/tab_presentation.rs @@ -95,7 +95,14 @@ impl NebulaWorkspace { .unwrap_or((None, SidebarActivity::Idle)); // 事件 vs 状态的唯一裁定处(侧栏与顶栏共用这份 presentation),规则与 // 理由见 [`sidebar::resting_activity`]。 - let activity = sidebar::resting_activity(activity, active, self.meta(ix).has_bell); + let show_status = cx + .try_global::() + .is_none_or(|settings| settings.show_tab_status); + let activity = if show_status { + sidebar::resting_activity(activity, active, self.meta(ix).has_bell) + } else { + SidebarActivity::Idle + }; let brand_logo = program.as_deref().and_then(crate::display::ai_logo_for_program); let logo_image = brand_logo.and_then(|logo| self.sidebar_logo_images.get(&(logo, dark)).cloned()); @@ -119,7 +126,10 @@ impl NebulaWorkspace { // 的 shell,只贴其中一个(聚焦那个)是误导;数量胶囊「这是一组」才是 // 此时该占这个槽位的信息。顺带把 28px 让回标题——顶栏挤到 120px 时, // 图标+胶囊+短标三样一起上,标题只剩两三个字符。 - let shell_tag = (is_terminal && activity == SidebarActivity::Idle && pane_count <= 1) + let shell_tag = (show_status + && is_terminal + && activity == SidebarActivity::Idle + && pane_count <= 1) .then_some(meta.shell_tag.clone()) .flatten() .filter(|tag| !tag.is_empty()); diff --git a/nebula_app/src/gpui_shell/workspace/top_tabs.rs b/nebula_app/src/gpui_shell/workspace/top_tabs.rs index a169c1a5e..7e6b77b2f 100644 --- a/nebula_app/src/gpui_shell/workspace/top_tabs.rs +++ b/nebula_app/src/gpui_shell/workspace/top_tabs.rs @@ -477,6 +477,7 @@ impl NebulaWorkspace { .inset_0() .justify_end() .items_center() + .debug_selector(move || format!("top-tab-status-{ix}")) .group_hover(hover_group.clone(), |item| item.invisible()) .child(status), ) @@ -492,6 +493,9 @@ impl NebulaWorkspace { .when(tab_close_visible || settings_navigation, |slot| { slot.child( Button::new(("top-close-tab", ix)) + .debug_selector(move || { + format!("close-top-tab-{ix}") + }) .icon(IconName::Close) .ghost() .xsmall() diff --git a/nebula_settings/src/lib.rs b/nebula_settings/src/lib.rs index 96a940976..adeaf2471 100644 --- a/nebula_settings/src/lib.rs +++ b/nebula_settings/src/lib.rs @@ -1012,6 +1012,8 @@ pub struct RuntimeSettings { pub multiline_paste_confirm: bool, /// 标签页关闭按钮(叉号)是否渲染:关 = 不渲染,仍可用中键关闭。 pub tab_close_visible: bool, + /// Presentation only; task observation and Runtime state remain active. + pub show_tab_status: bool, /// 新建本地终端是否把 Windows 系统代理写入代理环境变量。自定义代理地址 /// 不看这个开关:网络页填了地址就会写入新终端。默认关。已打开的会话不改。 pub terminal_proxy: bool, @@ -1189,6 +1191,7 @@ impl RuntimeSettings { dim_inactive_panes: raw.bool_on("dim_inactive_panes").unwrap_or(true), multiline_paste_confirm: raw.bool_on("multiline_paste_confirm").unwrap_or(true), tab_close_visible: raw.bool_on("tab_close_visible").unwrap_or(true), + show_tab_status: raw.bool_on("show_tab_status").unwrap_or(true), terminal_proxy: raw.bool_on("terminal_proxy").unwrap_or(false), refresh_environment: raw.bool_on("refresh_environment").unwrap_or(true), powerline: raw.bool_on("powerline").unwrap_or(true), @@ -1341,6 +1344,17 @@ pub fn format_hex_rgb(rgb: Rgb8) -> String { #[cfg(test)] mod tests { + #[test] + fn tab_status_visibility_defaults_on_and_round_trips() { + let original = "custom=keep\n"; + assert!(RuntimeSettings::from_raw(&RawSettings::from_text(original)).show_tab_status); + let off = apply_updates(original, &[("show_tab_status", "0".into())]); + assert!(!RuntimeSettings::from_raw(&RawSettings::from_text(&off)).show_tab_status); + let on = apply_updates(&off, &[("show_tab_status", "1".into())]); + assert!(RuntimeSettings::from_raw(&RawSettings::from_text(&on)).show_tab_status); + assert!(on.contains("custom=keep")); + } + #[test] fn environment_refresh_defaults_and_round_trips() { for text in ["", "refresh_environment=\n", "refresh_environment=invalid\n"] { diff --git a/nebula_settings/src/reset.rs b/nebula_settings/src/reset.rs index cdf499e56..d8c3a6e4a 100644 --- a/nebula_settings/src/reset.rs +++ b/nebula_settings/src/reset.rs @@ -26,6 +26,7 @@ const RESET_KEYS: &[&str] = &[ "dim_inactive_panes", "multiline_paste_confirm", "tab_close_visible", + "show_tab_status", "terminal_proxy", "refresh_environment", "powerline", @@ -132,6 +133,13 @@ mod tests { use super::*; use crate::{RawSettings, RuntimeSettings}; + #[test] + fn reset_restores_tab_status_visibility() { + let text = default_settings_text("show_tab_status=0\ncustom=keep\n"); + assert!(RuntimeSettings::from_raw(&RawSettings::from_text(&text)).show_tab_status); + assert!(text.contains("custom=keep")); + } + #[test] fn reset_preserves_explicit_hook_authorization_and_opt_out() { let text = "ai_hooks=0\nai_hooks_claude=0\nai_hooks_codex=1\nai_hooks_grok=1\n"; From 0762a49301e15388c9be0bec4091e1de5f1b8088 Mon Sep 17 00:00:00 2001 From: GeekMr <140129782+WilliamWang1721@users.noreply.github.com> Date: Sat, 3 Oct 2026 13:53:59 +0800 Subject: [PATCH 2/3] style(tabs): apply CI rustfmt corrections --- .../workspace/settings_navigation/ui_tests.rs | 12 +++++------- .../src/gpui_shell/workspace/tab_presentation.rs | 12 +++++------- 2 files changed, 10 insertions(+), 14 deletions(-) diff --git a/nebula_app/src/gpui_shell/workspace/settings_navigation/ui_tests.rs b/nebula_app/src/gpui_shell/workspace/settings_navigation/ui_tests.rs index 68d931b2c..c0cdd0a88 100644 --- a/nebula_app/src/gpui_shell/workspace/settings_navigation/ui_tests.rs +++ b/nebula_app/src/gpui_shell/workspace/settings_navigation/ui_tests.rs @@ -256,12 +256,7 @@ fn hiding_tab_status_keeps_hover_close_selection_keyboard_and_collapsed_title( }); }); for (position, row, status, close) in [ - ( - TabsPositionName::Sidebar, - "sidebar-tab-1", - "sidebar-tab-status-1", - "close-sidebar-tab-1", - ), + (TabsPositionName::Sidebar, "sidebar-tab-1", "sidebar-tab-status-1", "close-sidebar-tab-1"), (TabsPositionName::Top, "top-tab-1", "top-tab-status-1", "close-top-tab-1"), ] { for visible in [true, false, true, false] { @@ -290,7 +285,10 @@ fn hiding_tab_status_keeps_hover_close_selection_keyboard_and_collapsed_title( }); window.simulate_mouse_move(bounds.center(), None, Modifiers::default()); tab_bounds(row, &mut window); - assert!(window.debug_bounds(close).is_some(), "the hover close button remains laid out"); + assert!( + window.debug_bounds(close).is_some(), + "the hover close button remains laid out" + ); } click_tab(row, &mut window); workspace.read_with(&window, |workspace, _| assert_eq!(workspace.active, 1)); diff --git a/nebula_app/src/gpui_shell/workspace/tab_presentation.rs b/nebula_app/src/gpui_shell/workspace/tab_presentation.rs index 4475a2957..0c3a6e98f 100644 --- a/nebula_app/src/gpui_shell/workspace/tab_presentation.rs +++ b/nebula_app/src/gpui_shell/workspace/tab_presentation.rs @@ -126,13 +126,11 @@ impl NebulaWorkspace { // 的 shell,只贴其中一个(聚焦那个)是误导;数量胶囊「这是一组」才是 // 此时该占这个槽位的信息。顺带把 28px 让回标题——顶栏挤到 120px 时, // 图标+胶囊+短标三样一起上,标题只剩两三个字符。 - let shell_tag = (show_status - && is_terminal - && activity == SidebarActivity::Idle - && pane_count <= 1) - .then_some(meta.shell_tag.clone()) - .flatten() - .filter(|tag| !tag.is_empty()); + let shell_tag = + (show_status && is_terminal && activity == SidebarActivity::Idle && pane_count <= 1) + .then_some(meta.shell_tag.clone()) + .flatten() + .filter(|tag| !tag.is_empty()); let renaming = self .tab_rename .as_ref() From 2b6a693f477486d295bcbc9402e10b406f4748d2 Mon Sep 17 00:00:00 2001 From: GeekMr <140129782+WilliamWang1721@users.noreply.github.com> Date: Sat, 3 Oct 2026 14:17:42 +0800 Subject: [PATCH 3/3] test(tabs): establish hover input state for status toggles --- .../src/gpui_shell/workspace/settings_navigation/ui_tests.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/nebula_app/src/gpui_shell/workspace/settings_navigation/ui_tests.rs b/nebula_app/src/gpui_shell/workspace/settings_navigation/ui_tests.rs index c0cdd0a88..bcab999c7 100644 --- a/nebula_app/src/gpui_shell/workspace/settings_navigation/ui_tests.rs +++ b/nebula_app/src/gpui_shell/workspace/settings_navigation/ui_tests.rs @@ -249,6 +249,8 @@ fn hiding_tab_status_keeps_hover_close_selection_keyboard_and_collapsed_title( use nebula_settings::TabsPositionName; let (_directory, workspace, mut window) = open_workspace(2, cx); window.update(|window, cx| { + window.activate_window(); + cx.global_mut::().tab_reveal = nebula_settings::TabRevealName::Instant; workspace.update(cx, |workspace, cx| { workspace.close_settings(window, cx); workspace.active = 0; @@ -260,6 +262,7 @@ fn hiding_tab_status_keeps_hover_close_selection_keyboard_and_collapsed_title( (TabsPositionName::Top, "top-tab-1", "top-tab-status-1", "close-top-tab-1"), ] { for visible in [true, false, true, false] { + window.simulate_mouse_move(gpui::point(px(1.0), px(1.0)), None, Modifiers::default()); window.update(|_, cx| { workspace.update(cx, |workspace, cx| { workspace.active = 0; @@ -287,7 +290,7 @@ fn hiding_tab_status_keeps_hover_close_selection_keyboard_and_collapsed_title( tab_bounds(row, &mut window); assert!( window.debug_bounds(close).is_some(), - "the hover close button remains laid out" + "{close} remains laid out with status={visible}, row={bounds:?}" ); } click_tab(row, &mut window);