Make currentRange for all AxisModel implementations public to receive and private to modify #93
Closed
asynchaizer
started this conversation in
Ideas
Replies: 3 comments 3 replies
-
|
I think that makes sense. To match with the setViewRange function the variable name should be changed to viewRange, and to be consistent it should also be a member of the LinearAxisModel interface. |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
I pushed a commit yesterday to expose a viewRange property. Please give it a try. |
Beta Was this translation helpful? Give feedback.
2 replies
-
|
Is there a reason why viewRange is State<ClosedRange < Double > > instead of State<ClosedRange < T > >? |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi @gsteckman!
We can add a currentRange open to receive, because some custom calculations can be based on this value, for example
Accordingly, we can make the currentViewRange field public separately, or simply open this field for reading, but closed for writing:
What do you think about it?
Beta Was this translation helpful? Give feedback.
All reactions