diff --git a/app/cdash/tests/CMakeLists.txt b/app/cdash/tests/CMakeLists.txt index a8c612ffea..d52d715341 100644 --- a/app/cdash/tests/CMakeLists.txt +++ b/app/cdash/tests/CMakeLists.txt @@ -130,8 +130,6 @@ add_php_test(seconds_from_interval) add_php_test(extracttar) -add_php_test(passwordcomplexity) - add_legacy_unit_test(/CDash/Model/Build) add_legacy_unit_test(/CDash/Model/Repository) diff --git a/app/cdash/tests/test_passwordcomplexity.php b/app/cdash/tests/test_passwordcomplexity.php deleted file mode 100644 index 1d89cd4af6..0000000000 --- a/app/cdash/tests/test_passwordcomplexity.php +++ /dev/null @@ -1,57 +0,0 @@ -validator = new Password(); - } - - public function testPasswordComplexity(): void - { - $this->complexityTest('a', 1, 1); - $this->complexityTest('aA', 2, 1); - $this->complexityTest('aA1', 3, 1); - $this->complexityTest('aA1_', 4, 1); - - $this->complexityTest('a', 0, 2); - $this->complexityTest('aA', 0, 2); - $this->complexityTest('aA1', 0, 2); - $this->complexityTest('aA1_', 0, 2); - - $this->complexityTest('ab', 1, 2); - $this->complexityTest('abAB', 2, 2); - $this->complexityTest('abAB12', 3, 2); - $this->complexityTest('abAB12_%', 4, 2); - } - - public function complexityTest($password, $expected, $count): void - { - $found = $this->validator->computeComplexity($password, $count); - if ($found != $expected) { - $this->fail("Expected $expected for '$password' when count is $count, instead got $found"); - } - } -} diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index ce6298441a..aa19373d34 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -20201,36 +20201,6 @@ parameters: count: 1 path: app/cdash/tests/test_parallelsubmissions.php - - - rawMessage: 'Loose comparison via "!=" between mixed and mixed is not allowed.' - identifier: notEqual.notAllowed - count: 1 - path: app/cdash/tests/test_passwordcomplexity.php - - - - rawMessage: 'Method PasswordComplexityTestCase::complexityTest() has parameter $count with no type specified.' - identifier: missingType.parameter - count: 1 - path: app/cdash/tests/test_passwordcomplexity.php - - - - rawMessage: 'Method PasswordComplexityTestCase::complexityTest() has parameter $expected with no type specified.' - identifier: missingType.parameter - count: 1 - path: app/cdash/tests/test_passwordcomplexity.php - - - - rawMessage: 'Method PasswordComplexityTestCase::complexityTest() has parameter $password with no type specified.' - identifier: missingType.parameter - count: 1 - path: app/cdash/tests/test_passwordcomplexity.php - - - - rawMessage: Property PasswordComplexityTestCase::$validator has no type specified. - identifier: missingType.property - count: 1 - path: app/cdash/tests/test_passwordcomplexity.php - - rawMessage: ''' Call to deprecated function pdo_execute():