Skip to content

SDK references pinned versions of React, causing duplicate dependencies #81

@jordaaash

Description

@jordaaash

https://github.com/KeystoneHQ/keystone-airgaped-base/blob/67cadb8af7207adfa5de20094dc82c8cfb00831a/packages/sdk/package.json#L30-L55

This code pins the version of React + DOM to 16.13.1. Any React app that uses this library will end up with two versions of these dependencies, causing bundle bloat and other issues.

Additionally the dev dependencies of the same packages use newer versions, and are unpinned.

React applications should provide their own version of React, and libraries that need it should declare flexible peer dependencies and dev dependencies instead.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions