From 867d2983cb9f22afed3671b2a4e242dafadfb273 Mon Sep 17 00:00:00 2001
From: Anshul Singhvi <anshulsinghvi@gmail.com>
Date: Sat, 17 Jan 2026 07:26:13 -0500
Subject: [PATCH] Add LineString constructor for AbstractVector

Fixes GI.convert failing when geometry is backed by StaticArrays.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 src/basic_types.jl   |  5 +++++
 test/geointerface.jl | 23 +++++++++++++++++++++++
 2 files changed, 28 insertions(+)

diff --git a/src/basic_types.jl b/src/basic_types.jl
index 48e776d8..345e7f55 100644
--- a/src/basic_types.jl
+++ b/src/basic_types.jl
@@ -303,6 +303,11 @@ A LineString is a collection of points connected by line segments.
 struct LineString{Dim, T<:Real} <: AbstractGeometry{Dim, T}
     points::Vector{Point{Dim, T}}
 end
+
+function LineString(points::AbstractVector{Point{Dim, T}}) where {Dim, T}
+    return LineString{Dim,T}(convert(Vector{Point{Dim, T}}, points))
+end
+
 Base.length(ls::LineString) = length(coordinates(ls))
 Base.:(==)(a::LineString, b::LineString) = a.points == b.points
 coordinates(ls::LineString) = ls.points
diff --git a/test/geointerface.jl b/test/geointerface.jl
index 1c62aee7..bbe19426 100644
--- a/test/geointerface.jl
+++ b/test/geointerface.jl
@@ -129,3 +129,26 @@ end
     @test ext.Y == (0.0f0, 1.0f0)
     @test ext.Z == (0.0f0, 1.0f0)
 end
+
+@testset "Convert from StaticArrays" begin
+    using GeometryBasics.StaticArrays
+
+    # LineString from StaticVector
+    ls = GeoInterface.convert(GeometryBasics, GeoInterface.LineString(SA[(1.0, 2.0), (3.0, 4.0)]))
+    @test ls isa LineString{2, Float64}
+    @test length(ls) == 2
+    @test ls.points[1] == Point(1.0, 2.0)
+    @test ls.points[2] == Point(3.0, 4.0)
+
+    # Polygon from StaticVector of StaticVector rings
+    ring = GeoInterface.LinearRing(SA[(0.0, 0.0), (1.0, 0.0), (1.0, 1.0), (0.0, 1.0), (0.0, 0.0)])
+    poly = GeoInterface.convert(GeometryBasics, GeoInterface.Polygon(SA[ring]))
+    @test poly isa Polygon{2, Float64}
+
+    # MultiLineString from StaticVector
+    line1 = GeoInterface.LineString(SA[(1.0, 2.0), (3.0, 4.0)])
+    line2 = GeoInterface.LineString(SA[(5.0, 6.0), (7.0, 8.0)])
+    mls = GeoInterface.convert(GeometryBasics, GeoInterface.MultiLineString([line1, line2]))
+    @test mls isa MultiLineString{2, Float64}
+    @test length(mls) == 2
+end