From b498ff41a2f4cc82201ab61662ad98ff46828ad8 Mon Sep 17 00:00:00 2001 From: Jess Sullivan Date: Thu, 11 Jun 2026 00:08:11 -0400 Subject: [PATCH] chore(webkit-rbe): pin @playwright/test 1.59.1 exact + make webkit smokes executor-dispatchable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Alignment PR for the GF WebKit cell (GloriousFlywheel #884): the cell bakes nixpkgs playwright-driver 1.59.1 / webkit-2272, and WebKit revisions are playwright-version-locked (unlike the CDP-stable chromium lane), so the consumer must match EXACTLY: - @playwright/test ^1.60.0 -> 1.59.1 (exact pin, no caret — the Skeleton/ Tailwind precedent; bumping playwright without a matching cell image breaks the remote webkit lane silently-until-proof) - the 2 webkit smoke targets + //:webkit_smoke_suite gain flywheel-eligible + gloriousflywheel-rbe-candidate tags: .bazelrc.flywheel's --test_tag_filters=flywheel-eligible would otherwise filter the suite to ZERO tests remotely (a vacuous green). Targets stay , so nothing dispatches them until an explicit //:webkit_smoke_suite proof run. Verified at 1.59.1/webkit-2272: just check; bazelisk test //:webkit_smoke_suite 2/2 (--nocache_test_results); H1+overflow e2e 20/20 under webkit-mobile AND chromium-mobile; bazel query 'tests(//:webkit_smoke_suite)' non-vacuous. Local note: a playwright version change requires 'pnpm exec playwright install' — stale per-revision binaries in the shared ~/Library/Caches/ms-playwright make project scheduling nondeterministic. --- BUILD.bazel | 6 ++++++ package.json | 2 +- pnpm-lock.yaml | 26 +++++++++++++------------- 3 files changed, 20 insertions(+), 14 deletions(-) diff --git a/BUILD.bazel b/BUILD.bazel index 9c260d9..eca777c 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -556,6 +556,8 @@ js_test( ], entry_point = "scripts/bazel/run-playwright-webkit-shell-smoke.mjs", tags = [ + "flywheel-eligible", + "gloriousflywheel-rbe-candidate", "local-server-route-smoke", "manual", "playwright", @@ -576,6 +578,8 @@ js_test( ], entry_point = "scripts/bazel/run-playwright-webkit-mobile-hud-smoke.mjs", tags = [ + "flywheel-eligible", + "gloriousflywheel-rbe-candidate", "local-server-route-smoke", "manual", "playwright", @@ -589,6 +593,8 @@ js_test( test_suite( name = "webkit_smoke_suite", tags = [ + "flywheel-eligible", + "gloriousflywheel-rbe-candidate", "local-server-route-smoke", "manual", "playwright", diff --git a/package.json b/package.json index f5f2b6c..f60849e 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ "satellite.js": "^5.0.0" }, "devDependencies": { - "@playwright/test": "^1.60.0", + "@playwright/test": "1.59.1", "@skeletonlabs/skeleton": "4.15.2", "@skeletonlabs/skeleton-svelte": "4.15.2", "@sveltejs/adapter-node": "^5.5.4", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 9f50132..ecf17ec 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -41,8 +41,8 @@ importers: version: 5.0.0 devDependencies: '@playwright/test': - specifier: ^1.60.0 - version: 1.60.0 + specifier: 1.59.1 + version: 1.59.1 '@skeletonlabs/skeleton': specifier: 4.15.2 version: 4.15.2(tailwindcss@4.3.0) @@ -624,8 +624,8 @@ packages: resolution: {integrity: sha512-tmmZ3lQxAe/k/+rNnXQRawJ4NjxO2hqiOLTHvWchtGZULp4RyFeh6aU4XdOYBFe2KE1oShQTv4AblOs2iOrNnQ==} engines: {node: '>= 10.0.0'} - '@playwright/test@1.60.0': - resolution: {integrity: sha512-O71yZIbAh/PxDMNGns37GHBIfrVkEVyn+AXyIa5dOTfb4/xNvRWV+Vv/NMbNCtODB/pO7vLlF2OTmMVLhmr7Ag==} + '@playwright/test@1.59.1': + resolution: {integrity: sha512-PG6q63nQg5c9rIi4/Z5lR5IVF7yU5MqmKaPOe0HSc0O2cX1fPi96sUQu5j7eo4gKCkB2AnNGoWt7y4/Xx3Kcqg==} engines: {node: '>=18'} hasBin: true @@ -2040,13 +2040,13 @@ packages: resolution: {integrity: sha512-QP88BAKvMam/3NxH6vj2o21R6MjxZUAd6nlwAS/pnGvN9IVLocLHxGYIzFhg6fUQ+5th6P4dv4eW9jX3DSIj7A==} engines: {node: '>=12'} - playwright-core@1.60.0: - resolution: {integrity: sha512-9bW6zvX/m0lEbgTKJ6YppOKx8H3VOPBMOCFh2irXFOT4BbHgrx5hPjwJYLT40Lu+4qtD36qKc/Hn56StUW57IA==} + playwright-core@1.59.1: + resolution: {integrity: sha512-HBV/RJg81z5BiiZ9yPzIiClYV/QMsDCKUyogwH9p3MCP6IYjUFu/MActgYAvK0oWyV9NlwM3GLBjADyWgydVyg==} engines: {node: '>=18'} hasBin: true - playwright@1.60.0: - resolution: {integrity: sha512-hheHdokM8cdqCb0lcE3s+zT4t4W+vvjpGxsZlDnikarzx8tSzMebh3UiFtgqwFwnTnjYQcsyMF8ei2mCO/tpeA==} + playwright@1.59.1: + resolution: {integrity: sha512-C8oWjPR3F81yljW9o5OxcWzfh6avkVwDD2VYdwIGqTkl+OGFISgypqzfu7dOe4QNLL2aqcWBmI3PMtLIK233lw==} engines: {node: '>=18'} hasBin: true @@ -2897,9 +2897,9 @@ snapshots: '@parcel/watcher-win32-ia32': 2.5.6 '@parcel/watcher-win32-x64': 2.5.6 - '@playwright/test@1.60.0': + '@playwright/test@1.59.1': dependencies: - playwright: 1.60.0 + playwright: 1.59.1 '@polka/url@1.0.0-next.29': {} @@ -4443,11 +4443,11 @@ snapshots: picomatch@4.0.4: {} - playwright-core@1.60.0: {} + playwright-core@1.59.1: {} - playwright@1.60.0: + playwright@1.59.1: dependencies: - playwright-core: 1.60.0 + playwright-core: 1.59.1 optionalDependencies: fsevents: 2.3.2