From e1d55aacc3609c1a34f97b2dfd061f2220e1372a Mon Sep 17 00:00:00 2001 From: JeanPhilippeKernel Date: Sat, 22 Aug 2026 22:03:19 +0900 Subject: [PATCH] ci: fix tag_name priority for workflow_dispatch releases github.ref_name is 'main' on workflow_dispatch runs, so it was shadowing inputs.tag_name in the || chain. Artifacts were named Panzerfaust-main-* instead of Panzerfaust-1.5.0-*. Putting inputs.tag_name first fixes dispatch-triggered releases. --- .github/workflows/release-please.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index d1800c1..f6d5597 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -87,7 +87,7 @@ jobs: - name: Package artifacts run: | - VERSION="${{ needs.release-please.outputs.tag_name || github.ref_name || inputs.tag_name }}" + VERSION="${{ inputs.tag_name || needs.release-please.outputs.tag_name || github.ref_name }}" VERSION="${VERSION#v}" cd artifacts zip -r "Panzerfaust-${VERSION}-Windows-x64.zip" Windows-x64-Release/ @@ -97,7 +97,7 @@ jobs: - name: Upload to GitHub Release uses: softprops/action-gh-release@v2 with: - tag_name: ${{ needs.release-please.outputs.tag_name || github.ref_name || inputs.tag_name }} + tag_name: ${{ inputs.tag_name || needs.release-please.outputs.tag_name || github.ref_name }} files: | artifacts/Panzerfaust-*-Windows-x64.zip artifacts/Panzerfaust-*-macOS-arm64.zip