Skip to content

Commit b217774

Browse files
feat: pass --body-limit 40MB + require jss >=0.0.208 so large app installs fit (#80)
jspod spawns jss with no --body-limit, so it rode JSS's default cap. That blocked installing apps with a large git history through a pod — e.g. solid-chat/app's ~30MB pack (jss install does a full clone; JSS git-receive rejects shallow pushes), which 413'd against the old 10MB (and even the new 20MB) default. - Pass --body-limit 40MB when spawning jss (overridable via options.bodyLimit). 40MB clears the ~30MB pack with headroom without an over-permissive memory-DoS surface. - Require jss >=0.0.208 <0.0.211: --body-limit only actually reaches Fastify from the CLI as of 0.0.208 (#562) — before that the flag was dead wiring — and the range floats up to 0.0.210 without re-pinning. Bump jspod 0.0.47 → 0.0.48.
1 parent 0a3cbf0 commit b217774

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

lib/start.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,15 @@ export async function start(userOptions = {}) {
245245
'--root', options.root,
246246
'--notifications',
247247
'--conneg',
248-
'--mashlib-module', dataBrowserUrl
248+
'--mashlib-module', dataBrowserUrl,
249+
// Raise the request body limit above JSS's 20MB default so app
250+
// installs with a large git history fit — e.g. solid-chat/app's
251+
// ~30MB pack (`jss install` does a full clone; JSS git-receive
252+
// rejects shallow pushes). 40MB clears that with headroom without
253+
// an over-permissive memory-DoS surface. Needs jss >=0.0.208,
254+
// where --body-limit actually reaches Fastify from the CLI (#562) —
255+
// enforced by this package's dependency range.
256+
'--body-limit', options.bodyLimit || '40MB'
249257
];
250258

251259
if (options.multiuser) {

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "jspod",
3-
"version": "0.0.47",
3+
"version": "0.0.48",
44
"description": "JavaScript Solid Pod - Just works, batteries included",
55
"type": "module",
66
"main": "./lib/index.js",
@@ -60,6 +60,6 @@
6060
},
6161
"dependencies": {
6262
"chalk": "^5.6.2",
63-
"javascript-solid-server": "^0.0.207"
63+
"javascript-solid-server": ">=0.0.208 <0.0.211"
6464
}
6565
}

0 commit comments

Comments
 (0)