Commit 89d9fe7
committed
fix: address Copilot review on PR #7
Four legitimate catches from the review:
1. `--no-auth` was a no-op against JSS. Now forwards JSS's `--public`
flag so the pod actually skips WAC and accepts unauthenticated
reads/writes (verified: JSS prints "PUBLIC MODE ENABLED").
2. `JSS_SINGLE_USER_PASSWORD` env override was documented in the
README but not honoured — the CLI always passed `--single-user-
password me`, drowning out the env. Now the env value is read in
jspod, passed to JSS via the CLI flag, AND surfaced in the
banner ("Sign In (password from JSS_SINGLE_USER_PASSWORD)") so
the displayed credentials match reality.
3. Loopback detection was too strict — only 127.0.0.1 / localhost /
::1 were treated as safe. Expanded to the full 127.0.0.0/8 IPv4
range (covers Ubuntu's default 127.0.1.1 in /etc/hosts) and the
bracketed `[::1]` form a user might paste in by accident.
4. README First Run Guide had duplicated Step 3 / Step 4 left over
from the previous version. Renumbered and removed the obsolete
"Register with a passkey" step (registration is disabled in
single-user mode anyway).
Refs #1 #3 #61 parent ec27890 commit 89d9fe7
2 files changed
Lines changed: 25 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
| 248 | + | |
| 249 | + | |
256 | 250 | | |
| 251 | + | |
257 | 252 | | |
258 | 253 | | |
259 | 254 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
45 | 49 | | |
46 | | - | |
| 50 | + | |
| 51 | + | |
47 | 52 | | |
48 | 53 | | |
49 | 54 | | |
| |||
133 | 138 | | |
134 | 139 | | |
135 | 140 | | |
136 | | - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
137 | 145 | | |
138 | 146 | | |
139 | 147 | | |
| |||
142 | 150 | | |
143 | 151 | | |
144 | 152 | | |
| 153 | + | |
| 154 | + | |
145 | 155 | | |
146 | | - | |
147 | 156 | | |
148 | | - | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
149 | 160 | | |
150 | 161 | | |
151 | 162 | | |
| |||
193 | 204 | | |
194 | 205 | | |
195 | 206 | | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
196 | 214 | | |
197 | 215 | | |
198 | 216 | | |
| |||
0 commit comments