Commit c3a813d
committed
Address copilot pass 3 on #4
Three findings:
1. chooseFragmentAndBuildVm bug introduced in pass 2:
`buildEs256kVerificationMethod` returns `{ vm, jwk, kid }` but
I read `probe.publicKeyJwk` (always undefined). sameJwk() never
matched, so idempotent re-runs would walk to a fresh fragment
instead of reusing the existing same-key VM at lws-key-1. Fixed
to read `probe.jwk`.
(My pass-2 smoke test "passed" because it inlined the logic with
a hand-built `{ publicKeyJwk: jwk }` probe — wasn't exercising
the actual code. Real bug.)
2. revealLwsAuthSection() unconditionally set "no oidcIssuer" error
status when lastIssuer was missing. If a session was already
restored from IndexedDB the user's signed-in status got
clobbered with a pre-login warning. Now gated on `!session.isActive`.
3. README roadmap line still said "PATCHed" for the B.3 entry —
updated to match the implementation ("written into profile via
GET → merge → PUT with If-Match").1 parent a9ba933 commit c3a813d
2 files changed
Lines changed: 11 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
386 | 386 | | |
387 | 387 | | |
388 | 388 | | |
389 | | - | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
390 | 394 | | |
391 | 395 | | |
392 | 396 | | |
| |||
558 | 562 | | |
559 | 563 | | |
560 | 564 | | |
561 | | - | |
| 565 | + | |
562 | 566 | | |
| 567 | + | |
| 568 | + | |
563 | 569 | | |
| 570 | + | |
564 | 571 | | |
565 | 572 | | |
566 | 573 | | |
| |||
575 | 582 | | |
576 | 583 | | |
577 | 584 | | |
578 | | - | |
| 585 | + | |
579 | 586 | | |
580 | 587 | | |
581 | 588 | | |
| |||
0 commit comments