Commit 4faefbe
committed
BUG: Honor StopOptimization from IterationEvent in v4 optimizers
Add an immediate m_Stop check after InvokeEvent(IterationEvent()) in
ExhaustiveOptimizerv4, PowellOptimizerv4, and
OnePlusOneEvolutionaryOptimizerv4. Previously these optimizers would
continue advancing after an observer called StopOptimization() (or
StopWalking()) during IterationEvent, making it impossible to halt
from a callback.
This is the companion change to cf929f2 which added the same
pattern to the GradientDescentOptimizerv4 family. All v4 optimizers
now consistently stop before taking another step when Stop is
requested from an IterationEvent observer.1 parent 12c0cb7 commit 4faefbe
3 files changed
Lines changed: 18 additions & 0 deletions
File tree
- Modules/Numerics/Optimizersv4/include
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
137 | 142 | | |
138 | 143 | | |
139 | 144 | | |
| |||
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
260 | 267 | | |
261 | 268 | | |
262 | 269 | | |
| |||
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
498 | 498 | | |
499 | 499 | | |
500 | 500 | | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
501 | 507 | | |
502 | 508 | | |
503 | 509 | | |
| |||
0 commit comments