Date formats are confusing

[jgalazm]

It is not clear when a date object is or should be in a specific format (LSST or standard JS).
This is inconvienent, and causes the need of "deep cloning" the data array (see Charts.setData) and messes with SurveyControls inputs.

[jgalazm]

One possible solution is to set only one "date" value and add set/get methods to obtain the date on each format

expDate = {
  value: 123, //(from the database),
  get JSformat(){
   // returns "value" in standard format
  },
  get LSSTformat(){
  // returns "value" in LSST format
  }
};

[jgalazm]

Input date values

Data can enter through two different "paths", depending on the reproduction mode:

Playback:

• SurveyControls.DateSelection.setDate = Survey.setDataByDate receives two dates in LSST format
• Then calls Survey.fetchDataByDate.
• Then uses this result (array of objects) as input for setData, setState and setDate

Live:

• SurveyControls.ModeSelection.setLiveMode calls Survey.setLiveMode
• There it runs this.socket.on to execute Survey.receiveMsg(timeStamp) with every message received
• timeStamp.expDate is on LSST format
• At Survey.receiveMsg every displayedData that happened before the timeWindow from currentTime(LSST format) is dropped, and the current message is pushed into displayedData. Finally this.setData(displayedData) is called

Components using dates

Charts

• setDisplayedDateLimits(end): called from Survey.setDisplayedDateLimits(startDate,endDate) which is called from SurveyControl.PlayerControls.setDisplayedDateLimits on Playback mode
• setDate: called by Survey.setDataByDate which is called from SurveyControls.DateSelection on Playback mode
• setData:
  • Called by Survey.setData(data)
    • Which is only called in Survey by
      • setLiveMode and setPlayBackMode : this.setData([])`
      • setDataByDate: this.setData(res.results);
      • addObservation: this.setData(this.displayedData);
  • It 'deep clones' the received array
  • Then it sorts it in increasing order
  • Converts each date field to JS format
  • sets Charts states: data ,start, end, startAt, endAt(on playback mode and if data.length>0), using the processed data array.
  • start and end are passed to Slider
  • startAt, endAt and data are passed to Timeline and Histogram. data.expDate is in JS format here.