Skip to content

Code quality

Jump to bottom
Tom Clarke edited this page May 3, 2018 · 5 revisions

There is an enormous difference between the maintainability of good and bad code. Here is the status of each of the main modules.

Throughout module xx can be found in ./src/emulator/xx.fs or ./src/renderer/xx.fs.

Project Module Comments
emulator Expressions Excellent
emulator Memory LDR/STR excellent. LDM/STM Needs rewriting
emulator DP Excellent. The literal detection is very complex and hacked due to FABLE issues.
emulator Branch Excellent
emulator Misc Excellent
emulator ParseTop Excellent
emulator ExecutionTop Good (refactor RunInfo = LoadImage?)
renderer Tabs Needs some work and should have HTML mutable state moved to another module
renderer Settings Should be refactored extracting helper functions to simplify code
renderer Update Unclear - I expect it can be improved.
renderer MenuBar Excellent

NB - reworking the renderer using elmish-react would probably allow much more functional abstraction is this code and make it cleaner. See issue # 14

|

Clone this wiki locally