From 506dd220d9626c2e2f59d19c2013530c52928b98 Mon Sep 17 00:00:00 2001 From: VirtualMachinist Date: Tue, 27 Oct 2026 06:35:44 -0400 Subject: [PATCH] docs(core): rotate callers must reseal a vault that holds entries `commit_rotation` lays down an empty new-epoch manifest, so a rotation without reseal on a vault with entries hides them from the current epoch. State that requirement in the `rotate` module docs, on `commit_rotation` and in the crate overview. Docs only. --- crates/geode-core/src/lib.rs | 4 +++- crates/geode-core/src/rotate.rs | 7 +++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/crates/geode-core/src/lib.rs b/crates/geode-core/src/lib.rs index bddee02..1feee77 100644 --- a/crates/geode-core/src/lib.rs +++ b/crates/geode-core/src/lib.rs @@ -97,7 +97,9 @@ //! public key -- the operator never needs a recipient secret). The old epoch //! `recipients.json` is left untouched so a remaining recipient can still //! unwrap the **old** EK and open old-epoch objects without reseal; dropping a -//! recipient without reseal is a documented **incomplete revocation**. +//! recipient without reseal is a documented **incomplete revocation**. Callers +//! must reseal when the vault holds entries, since the new-epoch manifest +//! starts empty. //! `reseal` rewrites every old-epoch object under the new EK at the new epoch //! (fresh `object_id` per object) and writes a new-epoch manifest; a dropped //! recipient has no wrap of the new EK and cannot read the rewritten objects. diff --git a/crates/geode-core/src/rotate.rs b/crates/geode-core/src/rotate.rs index 7c3f4bd..93ad935 100644 --- a/crates/geode-core/src/rotate.rs +++ b/crates/geode-core/src/rotate.rs @@ -14,6 +14,9 @@ //! and open old-epoch objects (04 6). Dropping a recipient without reseal is //! a **documented incomplete revocation**: the dropped recipient retains //! their old-epoch wrap and can still read old objects (10-policy; SPEC). +//! Callers must reseal when the vault holds entries: `commit_rotation` lays +//! down an empty new-epoch manifest, so without a reseal the entries vanish +//! from the current epoch. //! //! ## Reseal //! @@ -161,6 +164,10 @@ pub fn plan_rotation(isk: &IdentitySecret, plan: &RotatePlan<'_>) -> Result