From 8f4b689777eb19c3670a4b4fa908c9125a6b1d05 Mon Sep 17 00:00:00 2001 From: Alessevan <44125445+Alessevan@users.noreply.github.com> Date: Fri, 8 May 2026 23:08:01 -0400 Subject: [PATCH 1/3] fix: counter was wrongly computed --- .../fr/redstom/asynclevelling/cron/VocalExperienceCron.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/fr/redstom/asynclevelling/cron/VocalExperienceCron.java b/src/main/java/fr/redstom/asynclevelling/cron/VocalExperienceCron.java index df5be79..ccb8867 100644 --- a/src/main/java/fr/redstom/asynclevelling/cron/VocalExperienceCron.java +++ b/src/main/java/fr/redstom/asynclevelling/cron/VocalExperienceCron.java @@ -41,14 +41,16 @@ public void compute() { .filter(user -> user.getVoiceState() != null) .filter(user -> !user.getVoiceState().isDeafened()) .filter(user -> !user.getVoiceState().isMuted()) - .peek(_ -> counter.incrementAndGet()) .toList(); if (members.size() < 2) { continue; } - members.forEach(member -> memberService.addXp(member, per30sec, "Voice activity")); + members.forEach(member -> { + counter.incrementAndGet(); + memberService.addXp(member, per30sec, "Voice activity"); + }); } } From 9db12ff2556d786205aef797f07d1dc64da11037 Mon Sep 17 00:00:00 2001 From: Alessevan <44125445+Alessevan@users.noreply.github.com> Date: Fri, 8 May 2026 23:16:01 -0400 Subject: [PATCH 2/3] refactor: remove unnecessary AtomicLong --- .../asynclevelling/cron/VocalExperienceCron.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/main/java/fr/redstom/asynclevelling/cron/VocalExperienceCron.java b/src/main/java/fr/redstom/asynclevelling/cron/VocalExperienceCron.java index ccb8867..6d79f1a 100644 --- a/src/main/java/fr/redstom/asynclevelling/cron/VocalExperienceCron.java +++ b/src/main/java/fr/redstom/asynclevelling/cron/VocalExperienceCron.java @@ -32,7 +32,7 @@ public class VocalExperienceCron { public void compute() { log.info("Starting xp experience cron"); - AtomicLong counter = new AtomicLong(); + long counter = 0L; for (Guild guild : bot.getGuilds()) { for (VoiceChannel channel : guild.getVoiceChannels()) { @@ -47,13 +47,11 @@ public void compute() { continue; } - members.forEach(member -> { - counter.incrementAndGet(); - memberService.addXp(member, per30sec, "Voice activity"); - }); + members.forEach(member -> memberService.addXp(member, per30sec, "Voice activity")); + counter += members.size(); } } - log.info("Xp experience cron complete and {} users updated", counter.get()); + log.info("Xp experience cron complete and {} users updated", counter); } } From fd0db7deca1d8c18eb9a9a5426e4aefa5a09bffd Mon Sep 17 00:00:00 2001 From: Alessevan <44125445+Alessevan@users.noreply.github.com> Date: Fri, 8 May 2026 23:18:19 -0400 Subject: [PATCH 3/3] fix: style violations --- .../java/fr/redstom/asynclevelling/cron/VocalExperienceCron.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/java/fr/redstom/asynclevelling/cron/VocalExperienceCron.java b/src/main/java/fr/redstom/asynclevelling/cron/VocalExperienceCron.java index 6d79f1a..50b249f 100644 --- a/src/main/java/fr/redstom/asynclevelling/cron/VocalExperienceCron.java +++ b/src/main/java/fr/redstom/asynclevelling/cron/VocalExperienceCron.java @@ -15,7 +15,6 @@ import org.springframework.stereotype.Service; import java.util.List; -import java.util.concurrent.atomic.AtomicLong; @Slf4j @Service