Review/serial and readme bunsarak#4
Open
Bunsarak27 wants to merge 9 commits into
Open
Conversation
Includes a partially-authored README file. However, there are still some changes to make, as there are sections which we cannot fill out yet. This commit was accidentally authored under my university GitHub identity, woops. --------- Co-authored-by: Izak Baldacchino <a1830164@student.adelaide.edu.au>
Follows the basic mergesort algorithm provided by the video shown on the assignment description. Other sources accessed include: cppreference.com (for memcpy).
Includes a Makefile based on a template I created for an old project (which can be found here: github.com/Izak8/gl). Build flags differ from original assignment; changed C standard from gnu89 to c11. gnu89 seems unecessarily limiting.
Just simply uses scopes to create predictable conditions. If the test executable isn't aborted by a failed assertion, then it is considered to pass.
…hat still has elements.Finish with a single memcpy from B[left..right] back to A had to remove <error.h> include so tests build locally
…hat still has elements.Finish with a single memcpy from B[left..right] back to A had to remove <error.h> include so tests build locally
…el_mergesort, No threading changes yet; parallel_mergesort() remains a stub,fix(sort): correct my_mergesort base case (use left >= right)
…rt stub:testing goes well- (base) bunsarakann@Bunsaraks-MacBook-Air concurrency-os-assignment3 % ./test-mergesort 1000 0 42 Sorting 1000 elements took 0.00 seconds. (base) bunsarakann@Bunsaraks-MacBook-Air concurrency-os-assignment3 % ./test-mergesort 1000000 0 42 Sorting 1000000 elements took 0.16 seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What’s in this PR:
I combined Izak merge function and buildargs with my my_mergesort functions, Matthew currently working on parallel_mergesort func.
others