Analyzer DLL import settings are not applied reliably during package restore

[kyubuns]

Hi, we are seeing an intermittent issue after introducing NuGetForUnity 4.5.0 into our Unity project.

Environment

• Unity: 6000.3.11f1 (mac)
• NuGetForUnity: 4.5.0
• Installed packages:
  • MasterMemory 3.0.4
  • MessagePack 3.1.4

Issue

On some team members’ machines, after restoring packages, Roslyn analyzer DLLs are imported with incorrect Unity PluginImporter settings.
For example, a DLL under:
NuGetPackages/InstalledPackages/MessagePackAnalyzer.3.1.4/analyzers/...
is imported as a normal managed plugin:

• Any Platform is enabled
• Desktop platforms such as Windows/Linux/macOS are checked
• The RoslynAnalyzer label is not assigned
  The expected result is that these analyzer DLLs are not referenced by any platform and have the RoslynAnalyzer label.

Workaround

Deleting NuGetPackages/InstalledPackages/ and running restore again fixes the import settings.

Reproducibility

This has happened to multiple team members, but once fixed, it does not reproduce easily. I also cannot reproduce it consistently on my own machine, so we do not yet know the exact conditions.
Has anyone seen a similar issue where analyzer DLL import settings or labels are not applied correctly during restore?

[JoC0de]

What install method are you using to install NuGetForUmity?

[kyubuns]

I'm using "Install as GIT dependency via Package Manager".

    "com.github-glitchenzo.nugetforunity": {
      "version": "https://github.com/GlitchEnzo/NuGetForUnity.git?path=/src/NuGetForUnity",
      "depth": 0,
      "source": "git",
      "dependencies": {},
      "hash": "acc1c7bc9ea34c33b830e40316fca52553878d29"
    },

[kyubuns]

I am still struggling to reproduce the problem myself, but I have my team members use the following script whenever the issue occurs for them.

var targets = Directory.GetDirectories("Packages/nuget-packages/InstalledPackages", "analyzers", SearchOption.AllDirectories)
    .SelectMany(x => Directory.GetFiles(x, "*.dll", SearchOption.AllDirectories))
    .Select(x => x.Replace('\\', '/'))
    .ToArray();

foreach (var target in targets)
{
    var asset = AssetDatabase.LoadMainAssetAtPath(target);
    var labels = AssetDatabase.GetLabels(asset);
    if (!labels.Contains("NuGetForUnity") || !labels.Contains("RoslynAnalyzer"))
    {
        labels = labels.Concat(new[] { "NuGetForUnity", "RoslynAnalyzer" }).Distinct().ToArray();
        AssetDatabase.SetLabels(asset, labels);
    }

    var importer = (PluginImporter) AssetImporter.GetAtPath(target);
    importer.ClearSettings();
    importer.SetCompatibleWithAnyPlatform(false);
    importer.SetCompatibleWithEditor(false);
    importer.SaveAndReimport();
}

AssetDatabase.SaveAssets();