|
| 1 | +const express = require('express'); |
| 2 | +const request = require('supertest'); |
| 3 | +const session = require('express-session'); |
| 4 | + |
| 5 | +const { SESSION_TTL_SECONDS, createSessionConfig } = require('../backend/config/session'); |
| 6 | + |
| 7 | +class TestSessionStore extends session.Store { |
| 8 | + constructor() { |
| 9 | + super(); |
| 10 | + this.sessions = new Map(); |
| 11 | + } |
| 12 | + |
| 13 | + get(sid, callback) { |
| 14 | + const sessionData = this.sessions.get(sid); |
| 15 | + callback(null, sessionData ? JSON.parse(sessionData) : null); |
| 16 | + } |
| 17 | + |
| 18 | + set(sid, sessionData, callback) { |
| 19 | + this.sessions.set(sid, JSON.stringify(sessionData)); |
| 20 | + callback(null); |
| 21 | + } |
| 22 | + |
| 23 | + destroy(sid, callback) { |
| 24 | + this.sessions.delete(sid); |
| 25 | + callback(null); |
| 26 | + } |
| 27 | +} |
| 28 | + |
| 29 | +function createStoreFactory(store = new TestSessionStore()) { |
| 30 | + const calls = []; |
| 31 | + |
| 32 | + return { |
| 33 | + calls, |
| 34 | + store, |
| 35 | + create(options) { |
| 36 | + calls.push(options); |
| 37 | + return store; |
| 38 | + }, |
| 39 | + }; |
| 40 | +} |
| 41 | + |
| 42 | +describe('Session configuration', () => { |
| 43 | + it('initializes connect-mongo with the configured Mongo URL and TTL', () => { |
| 44 | + const storeFactory = createStoreFactory(); |
| 45 | + |
| 46 | + const config = createSessionConfig({ |
| 47 | + mongoUrl: 'mongodb://127.0.0.1:27017/github_tracker_test', |
| 48 | + sessionSecret: 'test-secret', |
| 49 | + storeFactory, |
| 50 | + }); |
| 51 | + |
| 52 | + expect(storeFactory.calls).toEqual([{ |
| 53 | + mongoUrl: 'mongodb://127.0.0.1:27017/github_tracker_test', |
| 54 | + ttl: SESSION_TTL_SECONDS, |
| 55 | + }]); |
| 56 | + expect(config.store).toBe(storeFactory.store); |
| 57 | + expect(SESSION_TTL_SECONDS).toBe(14 * 24 * 60 * 60); |
| 58 | + }); |
| 59 | + |
| 60 | + it('does not fall back to express-session MemoryStore', () => { |
| 61 | + const config = createSessionConfig({ |
| 62 | + mongoUrl: 'mongodb://127.0.0.1:27017/github_tracker_test', |
| 63 | + sessionSecret: 'test-secret', |
| 64 | + storeFactory: createStoreFactory(), |
| 65 | + }); |
| 66 | + |
| 67 | + expect(config.store).toBeDefined(); |
| 68 | + expect(config.store instanceof session.MemoryStore).toBeFalse(); |
| 69 | + }); |
| 70 | + |
| 71 | + it('uses secure cookies in production only', () => { |
| 72 | + const productionConfig = createSessionConfig({ |
| 73 | + mongoUrl: 'mongodb://127.0.0.1:27017/github_tracker_test', |
| 74 | + sessionSecret: 'test-secret', |
| 75 | + nodeEnv: 'production', |
| 76 | + storeFactory: createStoreFactory(), |
| 77 | + }); |
| 78 | + const developmentConfig = createSessionConfig({ |
| 79 | + mongoUrl: 'mongodb://127.0.0.1:27017/github_tracker_test', |
| 80 | + sessionSecret: 'test-secret', |
| 81 | + nodeEnv: 'development', |
| 82 | + storeFactory: createStoreFactory(), |
| 83 | + }); |
| 84 | + |
| 85 | + expect(productionConfig.cookie.secure).toBeTrue(); |
| 86 | + expect(developmentConfig.cookie.secure).toBeFalse(); |
| 87 | + }); |
| 88 | + |
| 89 | + it('requires MongoDB configuration for persistent sessions', () => { |
| 90 | + expect(() => createSessionConfig({ |
| 91 | + mongoUrl: '', |
| 92 | + sessionSecret: 'test-secret', |
| 93 | + storeFactory: createStoreFactory(), |
| 94 | + })).toThrowError(/MONGO_URI/); |
| 95 | + }); |
| 96 | + |
| 97 | + it('persists session data through the configured store', async () => { |
| 98 | + const app = express(); |
| 99 | + |
| 100 | + app.use(session(createSessionConfig({ |
| 101 | + mongoUrl: 'mongodb://127.0.0.1:27017/github_tracker_test', |
| 102 | + sessionSecret: 'test-secret', |
| 103 | + storeFactory: createStoreFactory(), |
| 104 | + }))); |
| 105 | + app.get('/count', (req, res) => { |
| 106 | + req.session.views = (req.session.views || 0) + 1; |
| 107 | + res.json({ views: req.session.views }); |
| 108 | + }); |
| 109 | + |
| 110 | + const agent = request.agent(app); |
| 111 | + |
| 112 | + await agent.get('/count').expect(200, { views: 1 }); |
| 113 | + await agent.get('/count').expect(200, { views: 2 }); |
| 114 | + }); |
| 115 | +}); |
0 commit comments