-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Labels
code/featureSome feature is not implemented yetSome feature is not implemented yetgood first issueGood issues for new external contributorsGood issues for new external contributors
Description
github-actions/conform-pr/main.go
Lines 323 to 335 in 0d831dd
| // checkAutoMerge checks if PR's auto-merge is enabled. | |
| func checkAutoMerge(_ *githubactions.Action, pr *graphql.PullRequest, community bool) error { | |
| if pr.Closed || pr.AutoMerge { | |
| return nil | |
| } | |
| msg := `PR should have auto-merge enabled.` | |
| if community { | |
| msg += ` Don't worry, maintainers will enable it for you.` | |
| } | |
| return errors.New(msg) | |
| } |
conform-pr's auto-merge checker should check that the commit_title property matches PR's subject number plus the PR number with # and brackets. That is to ensure that auto-merge generates the right commit subject line after the PR title is edited.
Metadata
Metadata
Assignees
Labels
code/featureSome feature is not implemented yetSome feature is not implemented yetgood first issueGood issues for new external contributorsGood issues for new external contributors