From 539d1f7f5334f05169f21451202ecd23cc31186b Mon Sep 17 00:00:00 2001 From: Zach Vorhies Date: Fri, 2 Oct 2026 02:05:02 -0700 Subject: [PATCH] ci: remove duplicated cache-key-suffix keys from check-ubuntu.yml #1587 added a second cache-key-suffix to two setup-soldr `with:` blocks. Duplicate keys make the workflow invalid, so since 2026-10-01 check-ubuntu and ci-minimal (which calls it) fail on every push with 'workflow file issue' and run zero jobs: no clippy or unit tests ran on main. Co-Authored-By: Claude --- .github/workflows/check-ubuntu.yml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/check-ubuntu.yml b/.github/workflows/check-ubuntu.yml index 2f167f4f..0456e6e6 100644 --- a/.github/workflows/check-ubuntu.yml +++ b/.github/workflows/check-ubuntu.yml @@ -47,7 +47,9 @@ jobs: # Own build-cache store (setup-soldr#237): with no suffix this job # shared one Cargo.lock-keyed entry with ~10 other workflows, and # the first small job to save it (165 MB) froze it -- an exact hit - # never re-saves -- so every run recompiled ~240 crates. + # never re-saves -- so every run recompiled ~240 crates. Distinct + # from python-facade-tests below, whose 166MB cache otherwise won + # the shared entry over this job's 479MB save. cache-key-suffix: check-ubuntu cache: true build-cache: true @@ -63,11 +65,6 @@ jobs: # the steady-state size so the action only flags genuinely # runaway caches. Hard cap stays at the action default (6 GiB). cache-payload-warn-bytes: 2GiB - # Distinct from python-facade-tests below. With one shared key the - # job that finishes first owns the immutable entry: the facade job's - # 166MB fbuild-python-only cache won over this job's 479MB save, and - # PRs restored it at a 28-32% hit rate. - cache-key-suffix: check-ubuntu # No separate `cargo check`: clippy type-checks the same # `--workspace --all-targets` set, so a prior check only re-did that work. @@ -119,7 +116,6 @@ jobs: target-cache: true prebuild-deps: none linker: platform-default - cache-key-suffix: python-facades - name: Run embedded-CPython facade tests run: | uv python install 3.10