Skip to content

Commit 2a8afaf

Browse files
zackeeszackees
committed
Refresh platform boundary inventory after rebase
1 parent 300a367 commit 2a8afaf

4 files changed

Lines changed: 22 additions & 34 deletions

File tree

‎ci/platform_boundary_ledger.tsv‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ crates/fbuild-paths/src/executable_hash.rs attr_cfg #[cfg(unix)] 1 host host_mec
3232
crates/fbuild-paths/src/executable_hash.rs attr_cfg #[cfg(unix)] 2 host host_mechanic
3333
crates/fbuild-paths/src/executable_hash.rs attr_cfg #[cfg(unix)] 3 host host_mechanic
3434
crates/fbuild-paths/src/executable_hash.rs attr_cfg #[cfg(unix)] 4 host host_mechanic
35-
crates/fbuild-paths/src/executable_hash.rs attr_cfg #[cfg(unix)] 5 host host_mechanic
36-
crates/fbuild-paths/src/executable_hash.rs native_path std::os::unix::fs::MetadataExt 0 fs host_mechanic
3735
crates/fbuild-python/tests/python_facades.rs native_path std::env::current_exe 0 host_executable host_mechanic
3836
crates/fbuild-toolchain/src/toolchain/esp_qemu.rs attr_cfg #[cfg(not(windows))] 0 host_executable host_mechanic
3937
crates/fbuild-toolchain/src/toolchain/esp_qemu.rs attr_cfg #[cfg(not(windows))] 1 host_executable host_mechanic

‎ci/platform_boundary_research.tsv‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,12 @@ crates/fbuild-core/src/platform/linux/device.rs 33 native_path std::os::unix::fs
1010
crates/fbuild-core/src/platform/linux/device.rs 41 native_path libc:: process host_mechanic
1111
crates/fbuild-core/src/platform/linux/device.rs 41 native_path libc:: process host_mechanic
1212
crates/fbuild-core/src/platform/linux/fs.rs 2 native_path std::os::unix::fs::PermissionsExt fs host_mechanic
13-
crates/fbuild-core/src/platform/linux/fs.rs 40 native_path std::os::unix::fs::symlink fs host_mechanic
14-
crates/fbuild-core/src/platform/linux/fs.rs 84 native_path std::os::unix::ffi::OsStrExt process host_mechanic
15-
crates/fbuild-core/src/platform/linux/fs.rs 89 native_path libc:: process host_mechanic
16-
crates/fbuild-core/src/platform/linux/fs.rs 91 native_path libc:: process host_mechanic
17-
crates/fbuild-core/src/platform/linux/fs.rs 101 native_path libc:: process host_mechanic
13+
crates/fbuild-core/src/platform/linux/fs.rs 13 native_path std::os::unix::fs::MetadataExt fs host_mechanic
14+
crates/fbuild-core/src/platform/linux/fs.rs 57 native_path std::os::unix::fs::symlink fs host_mechanic
15+
crates/fbuild-core/src/platform/linux/fs.rs 101 native_path std::os::unix::ffi::OsStrExt process host_mechanic
16+
crates/fbuild-core/src/platform/linux/fs.rs 106 native_path libc:: process host_mechanic
17+
crates/fbuild-core/src/platform/linux/fs.rs 108 native_path libc:: process host_mechanic
18+
crates/fbuild-core/src/platform/linux/fs.rs 118 native_path libc:: process host_mechanic
1819
crates/fbuild-core/src/platform/linux/ipc.rs 1 native_path interprocess::local_socket ipc host_mechanic
1920
crates/fbuild-core/src/platform/linux/ipc.rs 2 native_path interprocess::local_socket ipc host_mechanic
2021
crates/fbuild-core/src/platform/linux/ipc.rs 3 native_path interprocess::os::unix ipc host_mechanic
@@ -23,11 +24,12 @@ crates/fbuild-core/src/platform/linux/ipc.rs 66 native_path std::os::unix::fs::P
2324
crates/fbuild-core/src/platform/linux/mod.rs 13 compile_host_fact std::env::consts::ARCH host host_mechanic
2425
crates/fbuild-core/src/platform/linux/process.rs 1 native_path std::os::unix::process::ExitStatusExt process host_mechanic
2526
crates/fbuild-core/src/platform/macos/fs.rs 2 native_path std::os::unix::fs::PermissionsExt fs host_mechanic
26-
crates/fbuild-core/src/platform/macos/fs.rs 40 native_path std::os::unix::fs::symlink fs host_mechanic
27-
crates/fbuild-core/src/platform/macos/fs.rs 84 native_path std::os::unix::ffi::OsStrExt process host_mechanic
28-
crates/fbuild-core/src/platform/macos/fs.rs 89 native_path libc:: process host_mechanic
29-
crates/fbuild-core/src/platform/macos/fs.rs 91 native_path libc:: process host_mechanic
30-
crates/fbuild-core/src/platform/macos/fs.rs 101 native_path libc:: process host_mechanic
27+
crates/fbuild-core/src/platform/macos/fs.rs 13 native_path std::os::unix::fs::MetadataExt fs host_mechanic
28+
crates/fbuild-core/src/platform/macos/fs.rs 57 native_path std::os::unix::fs::symlink fs host_mechanic
29+
crates/fbuild-core/src/platform/macos/fs.rs 101 native_path std::os::unix::ffi::OsStrExt process host_mechanic
30+
crates/fbuild-core/src/platform/macos/fs.rs 106 native_path libc:: process host_mechanic
31+
crates/fbuild-core/src/platform/macos/fs.rs 108 native_path libc:: process host_mechanic
32+
crates/fbuild-core/src/platform/macos/fs.rs 118 native_path libc:: process host_mechanic
3133
crates/fbuild-core/src/platform/macos/ipc.rs 1 native_path interprocess::local_socket ipc host_mechanic
3234
crates/fbuild-core/src/platform/macos/ipc.rs 2 native_path interprocess::local_socket ipc host_mechanic
3335
crates/fbuild-core/src/platform/macos/ipc.rs 3 native_path socket2:: ipc host_mechanic
@@ -43,10 +45,10 @@ crates/fbuild-core/src/platform/windows/device.rs 35 native_path windows_sys:: p
4345
crates/fbuild-core/src/platform/windows/fs.rs 2 native_path std::os::windows::ffi::OsStrExt process host_mechanic
4446
crates/fbuild-core/src/platform/windows/fs.rs 3 native_path std::os::windows::fs fs host_mechanic
4547
crates/fbuild-core/src/platform/windows/fs.rs 4 native_path std::os::windows::io::AsRawHandle process host_mechanic
46-
crates/fbuild-core/src/platform/windows/fs.rs 50 native_path std::os::windows::fs::symlink_dir fs host_mechanic
47-
crates/fbuild-core/src/platform/windows/fs.rs 78 native_path windows_sys:: process host_mechanic
48-
crates/fbuild-core/src/platform/windows/fs.rs 133 native_path windows_sys:: process host_mechanic
49-
crates/fbuild-core/src/platform/windows/fs.rs 177 native_path windows_sys:: process host_mechanic
48+
crates/fbuild-core/src/platform/windows/fs.rs 60 native_path std::os::windows::fs::symlink_dir fs host_mechanic
49+
crates/fbuild-core/src/platform/windows/fs.rs 88 native_path windows_sys:: process host_mechanic
50+
crates/fbuild-core/src/platform/windows/fs.rs 143 native_path windows_sys:: process host_mechanic
51+
crates/fbuild-core/src/platform/windows/fs.rs 187 native_path windows_sys:: process host_mechanic
5052
crates/fbuild-core/src/platform/windows/ipc.rs 1 native_path interprocess::local_socket ipc host_mechanic
5153
crates/fbuild-core/src/platform/windows/ipc.rs 2 native_path interprocess::local_socket ipc host_mechanic
5254
crates/fbuild-core/src/platform/windows/ipc.rs 3 native_path interprocess::os::windows ipc host_mechanic
@@ -98,9 +100,7 @@ crates/fbuild-paths/src/executable_hash.rs 23 attr_cfg #[cfg(unix)] host host_me
98100
crates/fbuild-paths/src/executable_hash.rs 66 attr_cfg #[cfg(not(unix))] host host_mechanic
99101
crates/fbuild-paths/src/executable_hash.rs 71 attr_cfg #[cfg(unix)] host host_mechanic
100102
crates/fbuild-paths/src/executable_hash.rs 76 attr_cfg #[cfg(unix)] host host_mechanic
101-
crates/fbuild-paths/src/executable_hash.rs 78 native_path std::os::unix::fs::MetadataExt fs host_mechanic
102-
crates/fbuild-paths/src/executable_hash.rs 94 attr_cfg #[cfg(unix)] host host_mechanic
103-
crates/fbuild-paths/src/executable_hash.rs 103 attr_cfg #[cfg(all(test,unix))] host host_mechanic
103+
crates/fbuild-paths/src/executable_hash.rs 85 attr_cfg #[cfg(all(test,unix))] host host_mechanic
104104
crates/fbuild-python/tests/python_facades.rs 317 native_path std::env::current_exe host_executable host_mechanic
105105
crates/fbuild-toolchain/src/toolchain/esp_qemu.rs 528 attr_cfg #[cfg(windows)] host_executable host_mechanic
106106
crates/fbuild-toolchain/src/toolchain/esp_qemu.rs 534 attr_cfg #[cfg(windows)] host_executable host_mechanic

‎ci/test_enforce_platform_boundary.py‎

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,9 @@ def setUpClass(cls) -> None:
1515

1616
def test_committed_exact_occurrence_ledger_matches_whole_tree(self) -> None:
1717
# Keep the row count explicit so additions to host mechanics require
18-
# a deliberate inventory update. Serial PTY tests and the merged
19-
# main-branch daemon/executable changes and the Windows file-URL
20-
# resolver fixture and its Windows-only import bring the total to 46.
21-
self.assertEqual(len(self.expected), 46)
18+
# a deliberate inventory update. The executable identity now lives
19+
# behind the platform boundary, leaving 44 occurrences.
20+
self.assertEqual(len(self.expected), 44)
2221
self.assertFalse(boundary.validate_ledger(self.expected))
2322
self.assertFalse(boundary.compare(self.expected, self.observed))
2423

@@ -102,17 +101,10 @@ def test_no_raw_host_fact_reads_remain_outside_the_boundary(self) -> None:
102101
)
103102

104103
def test_no_filesystem_mechanics_remain_outside_the_boundary(self) -> None:
105-
# The executable-hash implementation added on main uses Unix file
106-
# metadata; keep that one exception exact and reject any new site.
104+
# Filesystem mechanics belong behind the platform boundary.
107105
self.assertEqual(
108106
[(row.path, row.kind, row.normalized) for row in self.expected if row.capability == "fs"],
109-
[
110-
(
111-
"crates/fbuild-paths/src/executable_hash.rs",
112-
"native_path",
113-
"std::os::unix::fs::MetadataExt",
114-
)
115-
],
107+
[],
116108
)
117109

118110
def test_rp2040_filesystem_mechanics_use_the_neutral_facade(self) -> None:

‎dylints/enforce_platform_boundary/src/baseline.txt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ crates/fbuild-paths/src/executable_hash.rs attr_cfg unix 3
3131
crates/fbuild-paths/src/executable_hash.rs attr_cfg unix 4
3232
crates/fbuild-paths/src/executable_hash.rs attr_cfg unix 5
3333
crates/fbuild-paths/src/executable_hash.rs attr_cfg unix 6
34-
crates/fbuild-paths/src/executable_hash.rs attr_cfg unix 7
35-
crates/fbuild-paths/src/executable_hash.rs native_import std::os::unix 0
3634
crates/fbuild-python/tests/python_facades.rs native_import std::env::current_exe 0
3735
crates/fbuild-toolchain/src/toolchain/esp_qemu.rs attr_cfg windows 0
3836
crates/fbuild-toolchain/src/toolchain/esp_qemu.rs attr_cfg windows 1

0 commit comments

Comments
 (0)