From e03cd8c0ba93dc544be656d701d8af0b14af171c Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Wed, 15 Jul 2026 00:36:26 +0000
Subject: [PATCH] fix(player): count a play on real listening, not on metadata
 load
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

playCount was bumped in onLoadedMetadata, which fires as soon as a track's
metadata decodes — before playback and even if play() is rejected. So
skipping through tracks counted a play for each, and the count was credited to
`current`, which may already have changed after a rapid switch.

Count in onTimeUpdate once playback passes a threshold (5s, or halfway through
a shorter track), and credit loadedIdRef — the id the <audio> element is
actually loaded with. loadedIdRef is blanked at the start of each load and set
only when the element switches to the new track, so a timeupdate from the
still-playing previous track during the async blob read can't double-count it.

Verified in-browser: skipping a track before the threshold records no play;
listening past it records exactly one, on the correct track.

Fixes #8.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkDKh1Uo1a4D7n5wCKdcKF
---
 src/state/PlayerProvider.jsx | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/src/state/PlayerProvider.jsx b/src/state/PlayerProvider.jsx
index 610d3d5..f4a5e62 100644
--- a/src/state/PlayerProvider.jsx
+++ b/src/state/PlayerProvider.jsx
@@ -19,6 +19,7 @@ const MEDIA_ACTIONS = [
 export function PlayerProvider({ children }) {
   const audioRef = useRef(null)
   const countedRef = useRef(false) // so each play only bumps playCount once
+  const loadedIdRef = useRef(null) // the track id the <audio> element is loaded with
   const objectUrlRef = useRef(null) // current blob: URL, revoked when track changes
   const [missing, setMissing] = useState(false) // audio bytes not found
 
@@ -79,6 +80,10 @@ export function PlayerProvider({ children }) {
     if (!audio || !current) return
     let cancelled = false
     countedRef.current = false
+    // Blank the loaded-id until the element actually switches to this track, so
+    // a timeupdate from the still-playing PREVIOUS track (during the async blob
+    // read) can't be credited to it a second time.
+    loadedIdRef.current = null
     setMissing(false)
     // Reset the scrubber immediately so it doesn't show the previous track's
     // position/length until the new metadata arrives.
@@ -120,6 +125,7 @@ export function PlayerProvider({ children }) {
       revokePrev()
       if (!current.src) objectUrlRef.current = url
       audio.src = url
+      loadedIdRef.current = current.id // element is now this track → safe to count
       audio.loop = loopMode === 'one'
       audio.play().then(() => setIsPlaying(true)).catch(() => setIsPlaying(false))
     })()
@@ -200,6 +206,14 @@ export function PlayerProvider({ children }) {
   const onTimeUpdate = (e) => {
     const a = e.target
     setProgress(a.currentTime)
+    // Count a play only after real listening — a few seconds in, or halfway
+    // through a short track. Doing it here (not on loadedmetadata) means
+    // skipping past tracks no longer inflates playCount, and we credit the
+    // track the element is actually loaded with, not a since-changed `current`.
+    if (!countedRef.current && loadedIdRef.current && a.currentTime >= Math.min(5, (a.duration || 10) * 0.5)) {
+      countedRef.current = true
+      bumpPlayCount(loadedIdRef.current)
+    }
     // Feed the lock-screen scrubber on iOS.
     if ('mediaSession' in navigator && navigator.mediaSession.setPositionState && a.duration && Number.isFinite(a.duration)) {
       try {
@@ -215,11 +229,6 @@ export function PlayerProvider({ children }) {
   }
   const onLoadedMeta = (e) => {
     setDuration(e.target.duration || 0)
-    // Count a play shortly after it successfully starts.
-    if (current && !countedRef.current) {
-      countedRef.current = true
-      bumpPlayCount(current.id)
-    }
   }
   const onEnded = () => {
     // loop === 'one' is handled by audio.loop (no 'ended' fires).