--timecorrval does not accept negative values

[speleos]

msmod/src/msmod.c

Line 693 in 3dafc8c

modtimecorrval = strtod (getoptval(argcount, argvec, optind++) ,NULL);

If negative skew values are given, msmod returns the following:
ERROR Option --timecorrval requires a value, try -h for usage

./msmod -o test.XX.XXX..XXX.X.XXXX.XX.XX --quality 'Q' --actflags 1,1 --timecorrval -12 --loc 00 XX.XXXX..XXX.X.XXXX.XX.XX

[speleos]

The issue seems to stem from getoptval and its very strict interpretation that anything with prefixed by "--" or a "-" is an option.

using --timecorrval -- -12 also doesn't work, nor --timecorrval=-12.

[chad-earthscope]

Thanks for reporting this. The simple arg parser here:

msmod/src/msmod.c

Line 917 in 3dafc8c

getoptval (int argcount, char **argvec, int argopt)

needs additional exceptions for the timecorr and timecorrval arguments.

[speleos]

I believe this is the solution, could you please check if it this is enough?

/* Special case of '--timecorrval -X' */
if ( (argopt+1) < argcount && strcmp (argvec[argopt], "--timecorrval") == 0 )
if ( lisnumber(argvec[argopt+1]) )
return argvec[argopt+1];

[WayneCrawford]

Doesn’t --timecorrval “-12” work?

[speleos]

I believe we tried with quotes too, but it was back in February. I'll log in to the server and try to run it again. Afonso Loureiro http://www.aerograma.net

…

On Thu, 7 Nov 2024 at 12:29, Wayne Crawford ***@***.***> wrote: Doesn’t —timecorrel “-12” work? — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKIK7UNRSIAIRK7KTGRYRFTZ7M6IJAVCNFSM6AAAAABRK3RVASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRRHA3DOMJZGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>