Skip to content

Re-factor some EOS functions to not directly port GSW-C Toolbox code (license violation) #499

Description

@katsmith133

The GSW-C license permits redistribution "in source and binary forms, without modification". Porting the code into a kokkos kernel is modification (thank you to @xylar for pointing this out). So all TEOS-10 functions we implement need to be derived in some form from Roquet et al. 2015, the original 75-term polynomial for the EOS, and not referenced directly from the GSW-C toolbox code. The currently implemented functions calcGibbsDerivPt0Pt0, calcPtFromCt, calcCtFromPt, and calcCtFreezing are all likely in violation of this license's terms, and need to be re-factored similar to the specific volume derivatives @xylar has implemented in #485.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions