Namelist option clean-up

[cbegeman]

I think we want the Tendencies section to contain only the *TendencyEnable true/false options and not other options or nested sections.

Current:

Tendencies:
...
    VelDiffTendencyEnable: true
    ViscDel2: 1.0e3
    VelHyperDiffTendencyEnable: true
    ViscDel4: 1.2e11
    DivFactor: 1.0
...
    BottomDragTendency:
      Enable: true
      Mode: implicit
      Type: constant
      BottomDragCoeff: 1.0e-3
...
    TracerDiffTendencyEnable: false
    EddyDiff2: 10.0
    TracerHyperDiffTendencyEnable: false
    EddyDiff4: 0.0
...

Proposed:

VelDiff:
    ViscDel2: 1.0e3
    ViscDel4: 1.2e11
    DivFactor: 1.0
TracerDiff:
    TracerDel2: 10.0
    TracerDel4: 0.0
BottomDrag:
    Mode: implicit
    Type: constant
    Coeff: 1.0e-3
...
Tendencies:
...
    VelDiffTendencyEnable: true
    VelHyperDiffTendencyEnable: true
...
    BottomDragTendencyEnable: true
...
    TracerDiffTendencyEnable: false
    TracerHyperDiffTendencyEnable: false
...

[xylar]

@cbegeman, I completely agree and this was bothering me yesterday. I like the proposed suggestion.

[xylar]

The various VelDiff:, TracerDiff: could go under Tendencies:, and there could be an Enabled: section if we still want to organize all of these under Tendencies: for tidiness.

[xylar]

But I'm fine with not nesting, as you propose. I'm not sure there's much if any added value.

[cbegeman]

I think if we start nesting then almost every option is related to tendencies and could be nested.

[xylar]

Yes, I agree. The nesting is already starting to become meaningles.

[cbegeman]

The only potential downside I can think of is if users assume that there is a strict correspondence between the heading and the file name, e.g., ViscDel2 is fetched in Tendencies.cpp but I don't think this would be the assumption from most folks.

[xylar]

I agree. Most developers would find the options by searching, not by browsing the code. I think the correspondence in that sense doesn't need to be strict.

[cbegeman]

@sbrus89 Do you want to sign off on this before I begin work on this reorg (possibly after the coupled deadline)?

[sbrus89]

I think this is a good idea, but agree that it should take place after the coupled deadline. While it would be nice to do a reorg, I don't think it's critical at this point.