Support for other versions of Lua?

[emmericp]

I was looking into LuaJS for something is written in Lua 5.1 (and can't reasonably support later versions of Lua), so I was wondering if you would consider adding support for multiple different versions of Lua. At least Lua 5.1 is somewhat popular.

The required diff to make Lua 5.1 work is surprisingly small, I hacked this together: main...emmericp:LuaJS:lua5.1. Obviously has some small problems and that's obviously not meant to be merged, just a proof of concept how small the differences are.

Would you consider adding support for Lua 5.1 if I would clean up my patch a bit?

[Doridian]

@emmericp Usually I'd decline since of the maintenance needs, however this project doesn't need much maintenance, so I'd be fine keeping some extra code here.

Therefor I think we have several options here:

• You maintain a Lua 5.1 fork of the code
• Your 5.1 changes are merged into a branch, say, just call it lua-5.1 or whatever
• I really dislike this one, but: The 5.1 changes are put behind #ifdef in C code and some form of checks within JS to support both 5.1 and later in the same codebase

What benefits were you hoping to gain from the 5.1 work being upstreamed as opposed to maintaining the fork?

[ShalokShalom]

Ahm, I am looking for the information, which version this one targets?

[Doridian]

It targets latest stable with the lua submodule in this repo. Currently the target is 5.4.7