From 9a0b273cda64341ddc0fee5e9ed0d928866e1aab Mon Sep 17 00:00:00 2001 From: Charlie Harper <144284500+Charlie284@users.noreply.github.com> Date: Sat, 1 Aug 2026 16:05:36 -0500 Subject: [PATCH 1/2] fix: Persist subtitle font weight --- lib/models/settings/subtitle_settings_model.dart | 2 +- test/subtitle_settings_model_test.dart | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 test/subtitle_settings_model_test.dart diff --git a/lib/models/settings/subtitle_settings_model.dart b/lib/models/settings/subtitle_settings_model.dart index cb328bb49..aa5c6d8f9 100644 --- a/lib/models/settings/subtitle_settings_model.dart +++ b/lib/models/settings/subtitle_settings_model.dart @@ -108,7 +108,7 @@ class SubtitleSettingsModel { factory SubtitleSettingsModel.fromMap(Map map) { return const SubtitleSettingsModel().copyWith( fontSize: map['fontSize'] as double?, - fontWeight: FontWeight.values.firstWhereOrNull((element) => element.index == map['fontWeight'] as int?), + fontWeight: FontWeight.values.firstWhereOrNull((element) => element.value == map['fontWeight'] as int?), verticalOffset: map['verticalOffset'] as double?, color: colorFromJson(map['color']), outlineColor: colorFromJson(map['outlineColor']), diff --git a/test/subtitle_settings_model_test.dart b/test/subtitle_settings_model_test.dart new file mode 100644 index 000000000..c5aa53199 --- /dev/null +++ b/test/subtitle_settings_model_test.dart @@ -0,0 +1,13 @@ +import 'package:fladder/models/settings/subtitle_settings_model.dart'; +import 'package:flutter/material.dart'; +import 'package:flutter_test/flutter_test.dart'; + +void main() { + test('preserves bold font weight when serialized and restored', () { + const settings = SubtitleSettingsModel(fontWeight: FontWeight.bold); + + final restored = SubtitleSettingsModel.fromJson(settings.toJson()); + + expect(restored.fontWeight, FontWeight.bold); + }); +} From 56ba04f4ccd56aaa7fd0a3a8958a963d00358edf Mon Sep 17 00:00:00 2001 From: PartyDonut <42371342+PartyDonut@users.noreply.github.com> Date: Sun, 9 Aug 2026 14:47:20 +0200 Subject: [PATCH 2/2] Delete test/subtitle_settings_model_test.dart --- test/subtitle_settings_model_test.dart | 13 ------------- 1 file changed, 13 deletions(-) delete mode 100644 test/subtitle_settings_model_test.dart diff --git a/test/subtitle_settings_model_test.dart b/test/subtitle_settings_model_test.dart deleted file mode 100644 index c5aa53199..000000000 --- a/test/subtitle_settings_model_test.dart +++ /dev/null @@ -1,13 +0,0 @@ -import 'package:fladder/models/settings/subtitle_settings_model.dart'; -import 'package:flutter/material.dart'; -import 'package:flutter_test/flutter_test.dart'; - -void main() { - test('preserves bold font weight when serialized and restored', () { - const settings = SubtitleSettingsModel(fontWeight: FontWeight.bold); - - final restored = SubtitleSettingsModel.fromJson(settings.toJson()); - - expect(restored.fontWeight, FontWeight.bold); - }); -}