Sharing iP code quality feedback [for @Ditzchann]

[nus-se-script]

@Ditzchann We did an automated analysis of your code to detect potential areas to improve the code quality. We are sharing the results below, to help you improve the iP code further.

IMPORTANT: Note that the script looked for just a few easy-to-detect problems only, and at-most three example are given i.e., there can be other areas/places to improve.

Aspect: Tab Usage

Example from src/main/java/ToDoTask.java lines 2-2:

[TAB]public ToDoTask(String name) {

Example from src/main/java/ToDoTask.java lines 3-3:

[TAB][TAB]super(name);

Example from src/main/java/ToDoTask.java lines 4-4:

[TAB]}

Suggestion: As specified by the coding standard, use spaces instead of tabs.

Aspect: Naming boolean variables/methods

Example from src/main/java/Task.java lines 3-3:

	private boolean done;

Suggestion: Follow the given naming convention for boolean variables/methods (e.g., use a boolean-sounding prefix).You may ignore the above if you think the name already follows the convention (the script can report false positives in some cases)

Aspect: Brace Style

No easy-to-detect issues 👍

Aspect: Package Name Style

No easy-to-detect issues 👍

Aspect: Class Name Style

No easy-to-detect issues 👍

Aspect: Dead Code

No easy-to-detect issues 👍

Aspect: Method Length

No easy-to-detect issues 👍

Aspect: Class size

No easy-to-detect issues 👍

Aspect: Header Comments

No easy-to-detect issues 👍

Aspect: Recent Git Commit Messages

possible problems in commit f5781b0:

Added support for multiple tasks types

Added processing for DeadlineTask, TodoTask and EventTask

• Not in imperative mood (?)

possible problems in commit ca37fd1:

Added trimInput function to help process functions

• Not in imperative mood (?)

possible problems in commit c42d330:

Added EventTask.java

Added EventTask.java
Fixed some formatting errors

• Not in imperative mood (?)

Suggestion: Follow the given conventions for Git commit messages for future commits (do not modify past commit messages as doing so will change the commit timestamp that we used to detect your commit timings).

Aspect: Binary files in repo

No easy-to-detect issues 👍

---

ℹ️ The bot account used to post this issue is un-manned. Do not reply to this post (as those replies will not be read). Instead, contact cs2103@comp.nus.edu.sg if you want to follow up on this post.