Are PRs wanted? #247
|
@DevEmperor I saw @MyButtermilk created a few PRs with no reply at all. I also have great features on my private fork implemented I could share (but also built with latest Claude Opus, so treat them more like a feature/user flow blueprint rather than technical best practice). |
Replies: 2 comments 1 reply
|
Yes, absolutely — PRs are very welcome, and I'm sorry the open ones have been sitting there without a word. That's on me, and it isn't a signal about the contributions themselves. The honest reason is capacity: most of my time on Dictate goes into working through the issue tracker, which has been busy lately, and reviewing a PR properly is a different kind of work. It means reading the change, understanding how it interacts with the rest of the app, and often testing it on a device — so it doesn't fit into the gaps between issues, and I'd rather leave one sitting than merge something I haven't really looked at. @MyButtermilk — #172, #173 and #175 are on my list and I do intend to get to them. Thank you for taking the time, and sorry for the silence. On your fork: please do share it. And the framing you gave it — closer to a feature and user-flow blueprint than to finished code — is genuinely useful rather than a caveat. Quite often the hard part is deciding what something should do, and seeing a working version of that is worth a lot even when the implementation ends up being rewritten. If a change turns out to be large, opening an issue first to agree on the shape tends to save everyone effort. So: keep them coming. Just expect the reply to be slower than on issues. |
|
Actually I am quite happy that you already merged some of my ideas, thanks for that! And hey, we all have full days - no worries : ) |
@DevEmperor I invited you to my fork, feel free to start here: https://github.com/george1612/Dictate-Extended/discussions/92. Would love to hear your thoughts! :) |
Yes, absolutely — PRs are very welcome, and I'm sorry the open ones have been sitting there without a word. That's on me, and it isn't a signal about the contributions themselves.
The honest reason is capacity: most of my time on Dictate goes into working through the issue tracker, which has been busy lately, and reviewing a PR properly is a different kind of work. It means reading the change, understanding how it interacts with the rest of the app, and often testing it on a device — so it doesn't fit into the gaps between issues, and I'd rather leave one sitting than merge something I haven't really looked at.
@MyButtermilk — #172, #173 and #175 are on my list and I do intend to get to t…