On the dev branch: ### `Eject` - [x] A doesn't use `addRequirements()` - [x] B you don't need to use the `execute()` at all, since you're just setting speed and waiting. - [x] C doesn't check if both TOF sensors are clear before ending the command ### `Intake` - [x] D doesn't use `addRequirements()` - [x] E creates a NEW arm EVERY TIME it's run - [x] F uses the LED subsystem (do not) - [x] G unecessary outtake TOF check in periodic - [x] H tries to intake without waiting for the arm to finish moving ### `PassToOuttake` - [ ] I literally never needed to be changed - [x] K doesn't need rumble - [x] L doesn't need to move the arm - [x] M doesn't need to use `execute()` - [x] N `isFinished()` doesn't check the state of the outtake TOF sensor - [x] O STILL doesn't use `addRequirements()` - [ ] P stops the intake in the initialize??? - [x] Q only sets intake RPM even though both need to be spinning ### `RumbleNote` - [ ] R I can't even tell what's supposed to be happening here. - [ ] S ends before it starts the rumble (why did you do this??) - [ ] T horrendusly convoluted `execute` logic - [ ] U where comments - [ ] V doesn't use `addRequirements()` for the controller ### `RampToRPM` - [ ] W doesn't exist (should return finished when shooter RPM is within tolerance of an inputted RPM) ### `ArmToPos` - [ ] Y also doesn't exist (should return finished when arm has been moved within tolerance of an inputted position) when you add a commit that fixes some of these things, please also put the letter. Ex: `added comments to fix #34 L`
On the dev branch:
EjectaddRequirements()execute()at all, since you're just setting speed and waiting.IntakeaddRequirements()PassToOuttakeexecute()isFinished()doesn't check the state of the outtake TOF sensoraddRequirements()RumbleNoteexecutelogicaddRequirements()for the controllerRampToRPMArmToPoswhen you add a commit that fixes some of these things, please also put the letter.
Ex:
added comments to fix #34 L