From bc10b59907155724e94437806e857a4c2bd6a6e8 Mon Sep 17 00:00:00 2001 From: zachery with an e <45150570+zweatshirt@users.noreply.github.com> Date: Tue, 24 Feb 2026 08:57:22 -0600 Subject: [PATCH 1/5] Add NoRequestsDisplay component for MHA and its tests --- .../MainPages/NoRequestsDisplay.test.tsx | 32 +++++++++++++++++++ .../MainPages/NoRequestsDisplay.tsx | 20 ++++++++++++ 2 files changed, 52 insertions(+) create mode 100644 src/components/Reports/MinisterHousingAllowance/MainPages/NoRequestsDisplay.test.tsx create mode 100644 src/components/Reports/MinisterHousingAllowance/MainPages/NoRequestsDisplay.tsx diff --git a/src/components/Reports/MinisterHousingAllowance/MainPages/NoRequestsDisplay.test.tsx b/src/components/Reports/MinisterHousingAllowance/MainPages/NoRequestsDisplay.test.tsx new file mode 100644 index 0000000000..76cf851f5e --- /dev/null +++ b/src/components/Reports/MinisterHousingAllowance/MainPages/NoRequestsDisplay.test.tsx @@ -0,0 +1,32 @@ +import React from 'react'; +import { ThemeProvider } from '@mui/material/styles'; +import { LocalizationProvider } from '@mui/x-date-pickers'; +import { AdapterLuxon } from '@mui/x-date-pickers/AdapterLuxon'; +import { render } from '@testing-library/react'; +import theme from 'src/theme'; +import { NoRequestsDisplay } from './NoRequestsDisplay'; + +const TestComponent: React.FC = () => ( + + + + + +); + +describe('NoRequestsDisplay', () => { + it('should render no requests message', () => { + const { getByTestId } = render(); + + expect(getByTestId('no-requests-display')).toBeInTheDocument(); + }); + + it('should render contact email link', () => { + const { getByRole } = render(); + + expect(getByRole('link', { name: 'MHA@cru.org' })).toHaveAttribute( + 'href', + 'mailto:MHA@cru.org', + ); + }); +}); diff --git a/src/components/Reports/MinisterHousingAllowance/MainPages/NoRequestsDisplay.tsx b/src/components/Reports/MinisterHousingAllowance/MainPages/NoRequestsDisplay.tsx new file mode 100644 index 0000000000..eef59b4505 --- /dev/null +++ b/src/components/Reports/MinisterHousingAllowance/MainPages/NoRequestsDisplay.tsx @@ -0,0 +1,20 @@ +import { Box } from '@mui/material'; +import { Trans, useTranslation } from 'react-i18next'; + +export const NoRequestsDisplay: React.FC = () => { + const { t } = useTranslation(); + + return ( + + +

+ Our records indicate that you have not applied for Minister's + Housing Allowance. If you would like information about applying for + one, contact Personnel Records at{' '} + (407) 826-2230 or{' '} + MHA@cru.org. +

+ + + ); +}; From fff7e9f2c6cc2f17afbc3dec4f851398d69f2f64 Mon Sep 17 00:00:00 2001 From: zachery with an e <45150570+zweatshirt@users.noreply.github.com> Date: Tue, 24 Feb 2026 08:58:03 -0600 Subject: [PATCH 2/5] Enhance MinisterHousingAllowance component with eligibility checks and NoRequestsDisplay integration --- .../MinisterHousingAllowance.test.tsx | 55 ++++++++++++++++++- .../MinisterHousingAllowance.tsx | 42 +++++++++++--- .../MinisterHousingAllowanceContext.tsx | 8 +++ 3 files changed, 94 insertions(+), 11 deletions(-) diff --git a/src/components/Reports/MinisterHousingAllowance/MinisterHousingAllowance.test.tsx b/src/components/Reports/MinisterHousingAllowance/MinisterHousingAllowance.test.tsx index 6f7f06cbfa..dcb60e02a9 100644 --- a/src/components/Reports/MinisterHousingAllowance/MinisterHousingAllowance.test.tsx +++ b/src/components/Reports/MinisterHousingAllowance/MinisterHousingAllowance.test.tsx @@ -8,8 +8,10 @@ import { MhaStatusEnum } from 'src/graphql/types.generated'; import theme from 'src/theme'; import { HcmDataQuery } from '../Shared/HcmData/HCMData.generated'; import { + marriedBothIneligible, marriedMhaAndNoException, marriedNoMhaNoException, + singleIneligible, singleMhaNoException, singleNoMhaNoException, } from '../Shared/HcmData/mockData'; @@ -74,9 +76,6 @@ describe('MinisterHousingAllowanceReport', () => { expect( await findByText(/our records indicate that you have not applied for/i), ).toBeInTheDocument(); - expect( - await findByText(/will submit the request for john. jane has not/i), - ).toBeInTheDocument(); expect(await findByText('John Doe and Jane Doe')).toBeInTheDocument(); }); @@ -127,6 +126,56 @@ describe('MinisterHousingAllowanceReport', () => { expect(getByText('Current Board Approved MHA')).toBeInTheDocument(); }); + it('renders fully ineligible single user with requests and hides request details', async () => { + const { findByText, queryByText } = render( + , + ); + + expect( + await findByText(/you have not completed the required ibs courses/i), + ).toBeInTheDocument(); + + expect( + queryByText(/our records indicate that you have an mha request/i), + ).not.toBeInTheDocument(); + }); + + it('renders fully ineligible married couple and hides request details', async () => { + const { findByText, queryByText } = render( + , + ); + + expect( + await findByText(/have not completed the required ibs courses/i), + ).toBeInTheDocument(); + + expect(queryByText('Current Board Approved MHA')).not.toBeInTheDocument(); + expect( + queryByText(/our records indicate that you have an approved/i), + ).not.toBeInTheDocument(); + }); + it('renders married, pending, no approved correctly', async () => { const { findByText } = render( { isMarried, preferredName, spousePreferredName, + userEligibleForMHA, + spouseEligibleForMHA, userHcmData, spouseHcmData, } = useMinisterHousingAllowance(); @@ -94,8 +97,6 @@ export const MinisterHousingAllowanceReport = () => { }); }; - const hasNoRequests = !requests.length; - const currentRequest = requests[0] || {}; // It default to true when no availableDate as the request is likely still being processed const isCurrentRequestPending = @@ -113,6 +114,18 @@ export const MinisterHousingAllowanceReport = () => { isCurrentRequestPending, ); + const hasNoRequests = !requests.length; + + const bothEligible = userEligibleForMHA && spouseEligibleForMHA; + const eitherPersonEligible = userEligibleForMHA || spouseEligibleForMHA; + + const showIneligibleDisplay = + !userEligibleForMHA || (isMarried && !bothEligible); + const showNewRequestButton = + eitherPersonEligible && (!isCurrentRequestPending || hasNoRequests); + const showCurrentRequest = eitherPersonEligible && currentRequest; + const showPreviousRequests = eitherPersonEligible && previousApprovedRequest; + return ( { ) : ( <> + + {t('Your MHA')} + + {hasNoRequests ? ( - + <> + + {showIneligibleDisplay && } + ) : ( - + <> + {showIneligibleDisplay && } + {eitherPersonEligible && ( + + )} + )} + - {currentRequest && + {showCurrentRequest && (isCurrentRequestPending ? ( ) : ( ))} - {(!isCurrentRequestPending || hasNoRequests) && ( + {showNewRequestButton && ( )} - {previousApprovedRequest && ( + {showPreviousRequests && ( diff --git a/src/components/Reports/MinisterHousingAllowance/Shared/Context/MinisterHousingAllowanceContext.tsx b/src/components/Reports/MinisterHousingAllowance/Shared/Context/MinisterHousingAllowanceContext.tsx index 285aca8f03..86ace0a7c2 100644 --- a/src/components/Reports/MinisterHousingAllowance/Shared/Context/MinisterHousingAllowanceContext.tsx +++ b/src/components/Reports/MinisterHousingAllowance/Shared/Context/MinisterHousingAllowanceContext.tsx @@ -53,6 +53,7 @@ export type ContextType = { preferredName: string; spousePreferredName: string; userEligibleForMHA: boolean; + spouseEligibleForMHA: boolean; handleDiscard: () => Promise; requestData?: @@ -198,6 +199,11 @@ export const MinisterHousingAllowanceProvider: React.FC = ({ [userHcmData], ); + const spouseEligibleForMHA = useMemo( + () => spouseHcmData?.mhaEit?.mhaEligibility ?? false, + [spouseHcmData], + ); + const [isDrawerOpen, setIsDrawerOpen] = useState(true); const toggleDrawer = useCallback(() => { setIsDrawerOpen((prev) => !prev); @@ -227,6 +233,7 @@ export const MinisterHousingAllowanceProvider: React.FC = ({ preferredName, spousePreferredName, userEligibleForMHA, + spouseEligibleForMHA, handleDiscard, setIsComplete, requestData: requestData?.ministryHousingAllowanceRequest ?? null, @@ -256,6 +263,7 @@ export const MinisterHousingAllowanceProvider: React.FC = ({ preferredName, spousePreferredName, userEligibleForMHA, + spouseEligibleForMHA, handleDiscard, requestData, requestError, From d9ff4b1ccc3ed472cd8dbdc2a4527833dfa395dd Mon Sep 17 00:00:00 2001 From: zachery with an e <45150570+zweatshirt@users.noreply.github.com> Date: Tue, 24 Feb 2026 08:59:08 -0600 Subject: [PATCH 3/5] Refactor IneligibleDisplay component to consider Spouse, refactor EligibleDisplay --- .../MainPages/EligibleDisplay.test.tsx | 6 +- .../MainPages/EligibleDisplay.tsx | 54 ++++---- .../MainPages/IneligibleDisplay.test.tsx | 77 +++++++----- .../MainPages/IneligibleDisplay.tsx | 118 ++++++++++++------ 4 files changed, 150 insertions(+), 105 deletions(-) diff --git a/src/components/Reports/MinisterHousingAllowance/MainPages/EligibleDisplay.test.tsx b/src/components/Reports/MinisterHousingAllowance/MainPages/EligibleDisplay.test.tsx index 379910247a..449dcdcd31 100644 --- a/src/components/Reports/MinisterHousingAllowance/MainPages/EligibleDisplay.test.tsx +++ b/src/components/Reports/MinisterHousingAllowance/MainPages/EligibleDisplay.test.tsx @@ -19,17 +19,15 @@ const TestComponent: React.FC = ({ isPending }) => ( ); describe('EligibleDisplay', () => { - it('should render title and message when pending is true', () => { + it('should render message when pending is true', () => { const { getByText } = render(); - expect(getByText('Your MHA')).toBeInTheDocument(); expect(getByText(/waiting to be processed/i)).toBeInTheDocument(); }); - it('should render title and message when pending is false', () => { + it('should render message when pending is false', () => { const { getByText } = render(); - expect(getByText('Your MHA')).toBeInTheDocument(); expect( getByText(/our records indicate that you have an approved mha amount/i), ).toBeInTheDocument(); diff --git a/src/components/Reports/MinisterHousingAllowance/MainPages/EligibleDisplay.tsx b/src/components/Reports/MinisterHousingAllowance/MainPages/EligibleDisplay.tsx index 121ec8c478..8039e03cac 100644 --- a/src/components/Reports/MinisterHousingAllowance/MainPages/EligibleDisplay.tsx +++ b/src/components/Reports/MinisterHousingAllowance/MainPages/EligibleDisplay.tsx @@ -1,5 +1,5 @@ -import { Box, Typography } from '@mui/material'; -import { Trans, useTranslation } from 'react-i18next'; +import { Box } from '@mui/material'; +import { Trans } from 'react-i18next'; interface EligibleDisplayProps { isPending: boolean; @@ -8,34 +8,28 @@ interface EligibleDisplayProps { export const EligibleDisplay: React.FC = ({ isPending, }) => { - const { t } = useTranslation(); return ( - <> - - {t('Your MHA')} - - - {isPending ? ( - -

- Our records indicate that you have an MHA request{' '} - waiting to be processed. To view your MHA - request, click on the "View Current MHA" button below. - If you would like to make changes to your request, click on the - "Edit Request" button below. -

- - ) : ( - -

- Our records indicate that you have an approved MHA amount. To view - your MHA amount, click on the "View Current MHA" button - below. If you would like to apply for a new MHA, click - "Update Current MHA". -

- - )} - - + + {isPending ? ( + +

+ Our records indicate that you have an MHA request{' '} + waiting to be processed. To view your MHA request, + click on the "View Current MHA" button below. If you would + like to make changes to your request, click on the "Edit + Request" button below. +

+ + ) : ( + +

+ Our records indicate that you have an approved MHA amount. To view + your MHA amount, click on the "View Current MHA" button + below. If you would like to apply for a new MHA, click "Update + Current MHA". +

+ + )} + ); }; diff --git a/src/components/Reports/MinisterHousingAllowance/MainPages/IneligibleDisplay.test.tsx b/src/components/Reports/MinisterHousingAllowance/MainPages/IneligibleDisplay.test.tsx index b0b8b9cb5b..5cbd9e2da3 100644 --- a/src/components/Reports/MinisterHousingAllowance/MainPages/IneligibleDisplay.test.tsx +++ b/src/components/Reports/MinisterHousingAllowance/MainPages/IneligibleDisplay.test.tsx @@ -6,7 +6,6 @@ import { render } from '@testing-library/react'; import theme from 'src/theme'; import { ContextType, - HcmData, MinisterHousingAllowanceContext, } from '../Shared/Context/MinisterHousingAllowanceContext'; import { IneligibleDisplay } from './IneligibleDisplay'; @@ -30,57 +29,67 @@ const TestComponent: React.FC = ({ contextValue }) => { }; describe('IneligibleDisplay', () => { - it('should render page with single staff', () => { - const { getByText, queryByText } = render( + it('should render single user ineligible message', () => { + const { getByTestId } = render( , + ); + + expect(getByTestId('single-ineligible')).toBeInTheDocument(); + }); + + it('should render both ineligible message when neither user is eligible', () => { + const { getByTestId } = render( + , + ); + + expect(getByTestId('both-ineligible')).toBeInTheDocument(); + }); + + it('should render user ineligible message when user ineligible', () => { + const { getByTestId } = render( + , ); - expect(getByText('Your MHA')).toBeInTheDocument(); - expect( - getByText( - /our records indicate that you have not applied for minister's housing allowance/i, - ), - ).toBeInTheDocument(); - expect( - queryByText(/Jane has not completed the required ibs courses/i), - ).not.toBeInTheDocument(); + expect(getByTestId('one-ineligible')).toBeInTheDocument(); }); - it('should render page with married staff', () => { - const { getByText } = render( + it('should render spouse ineligible message when spouse ineligible', () => { + const { getByTestId } = render( , ); - expect( - getByText(/Jane has not completed the required ibs courses/i), - ).toBeInTheDocument(); + expect(getByTestId('one-ineligible')).toBeInTheDocument(); }); }); diff --git a/src/components/Reports/MinisterHousingAllowance/MainPages/IneligibleDisplay.tsx b/src/components/Reports/MinisterHousingAllowance/MainPages/IneligibleDisplay.tsx index 6de04f8293..c9ebd17f7d 100644 --- a/src/components/Reports/MinisterHousingAllowance/MainPages/IneligibleDisplay.tsx +++ b/src/components/Reports/MinisterHousingAllowance/MainPages/IneligibleDisplay.tsx @@ -1,53 +1,97 @@ -import { Box, Typography } from '@mui/material'; +import { Box } from '@mui/material'; import { Trans, useTranslation } from 'react-i18next'; import { useMinisterHousingAllowance } from '../Shared/Context/MinisterHousingAllowanceContext'; export const IneligibleDisplay: React.FC = () => { - const { t } = useTranslation(); - const { isMarried, preferredName, spousePreferredName } = - useMinisterHousingAllowance(); + const { + isMarried, + preferredName, + spousePreferredName, + userEligibleForMHA, + spouseEligibleForMHA, + } = useMinisterHousingAllowance(); - // TODO - Add spouse to API and check eligibility - // We will get this from HCM data in the future - const spouseEligibleForMHA = false; + const { t } = useTranslation(); - return ( - <> - - {t('Your MHA')} + if (!isMarried) { + return ( + + +

+ You have not completed the required IBS courses to meet eligibility + criteria. +

+

+ Once approved, when you calculate your salary, you will see the + approved amount that can be applied to your salary. If you believe + this is incorrect, please contact Personnel Records at{' '} + (407) 826-2230 or{' '} + MHA@cru.org. +

+ - + ); + } + + const bothIneligible = !userEligibleForMHA && !spouseEligibleForMHA; + + if (bothIneligible) { + return ( +

- Our records indicate that you have not applied for Minister's - Housing Allowance. If you would like information about applying for - one, contact Personnel Records at{' '} - (407) 826-2230 or{' '} + {'{{preferredName}}'} and {'{{spousePreferredName}}'} have not + completed the required IBS courses to meet eligibility criteria. +

+

+ Once approved, when you calculate your salary, you will see the + approved amount that can be applied to {'{{preferredName}}'} and{' '} + {'{{spousePreferredName}}'}'s salary. If you believe this is + incorrect, please contact Personnel Records at{' '} + (407) 826-2230 or{' '} MHA@cru.org.

- {isMarried && spouseEligibleForMHA === false && ( - - -

- Completing a Minister's Housing Allowance will submit the - request for {preferredName}. {spousePreferredName} has not - completed the required IBS courses to meet eligibility criteria. -

-

- Once approved, when you calculate your salary, you will see the - approved amount that can be applied to {preferredName}'s - salary. If you believe this is incorrect, please contact - Personnel Records at{' '} - (407) 826-2230 or{' '} - MHA@cru.org. -

- - - )} - + ); + } + + const eligibleUserName = userEligibleForMHA + ? preferredName + : spousePreferredName; + const ineligibleUserName = userEligibleForMHA + ? spousePreferredName + : preferredName; + + return ( + + +

+ Completing a Minister's Housing Allowance will submit the request + for {'{{eligibleUserName}}'}. {'{{ineligibleUserName}}'} has not + completed the required IBS courses to meet eligibility criteria. +

+

+ Once approved, when you calculate your salary, you will see the + approved amount that can be applied to {'{{ineligibleUserName}}'} + 's salary. If you believe this is incorrect, please contact + Personnel Records at + (407) 826-2230 + or MHA@cru.org. +

+ + ); }; From 8693c1d17e3b413e112bd805d92df5f2bfde60e0 Mon Sep 17 00:00:00 2001 From: zachery with an e <45150570+zweatshirt@users.noreply.github.com> Date: Tue, 24 Feb 2026 08:59:36 -0600 Subject: [PATCH 4/5] Add spouse eligibility check to RequestPage and update mock data for ineligible scenarios --- .../RequestPage/RequestPage.tsx | 3 ++- src/components/Reports/Shared/HcmData/mockData.ts | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/components/Reports/MinisterHousingAllowance/RequestPage/RequestPage.tsx b/src/components/Reports/MinisterHousingAllowance/RequestPage/RequestPage.tsx index 513dc425b6..d52b09f3b4 100644 --- a/src/components/Reports/MinisterHousingAllowance/RequestPage/RequestPage.tsx +++ b/src/components/Reports/MinisterHousingAllowance/RequestPage/RequestPage.tsx @@ -52,6 +52,7 @@ export const RequestPage: React.FC = () => { requestData, loading, userEligibleForMHA, + spouseEligibleForMHA, } = useMinisterHousingAllowance(); const canEdit = @@ -116,7 +117,7 @@ export const RequestPage: React.FC = () => { } /> - ) : !userEligibleForMHA ? ( + ) : !userEligibleForMHA && !spouseEligibleForMHA ? ( Date: Tue, 3 Mar 2026 09:19:54 -0600 Subject: [PATCH 5/5] Add tests for married users with mixed eligibility scenarios in MinisterHousingAllowanceReport --- .../MinisterHousingAllowance.test.tsx | 40 +++++++++++++++++++ .../Reports/Shared/HcmData/mockData.ts | 14 +++++++ 2 files changed, 54 insertions(+) diff --git a/src/components/Reports/MinisterHousingAllowance/MinisterHousingAllowance.test.tsx b/src/components/Reports/MinisterHousingAllowance/MinisterHousingAllowance.test.tsx index dcb60e02a9..ab6f80f5d4 100644 --- a/src/components/Reports/MinisterHousingAllowance/MinisterHousingAllowance.test.tsx +++ b/src/components/Reports/MinisterHousingAllowance/MinisterHousingAllowance.test.tsx @@ -11,6 +11,8 @@ import { marriedBothIneligible, marriedMhaAndNoException, marriedNoMhaNoException, + marriedUserEligibleSpouseIneligible, + marriedUserIneligibleSpouseEligible, singleIneligible, singleMhaNoException, singleNoMhaNoException, @@ -176,6 +178,44 @@ describe('MinisterHousingAllowanceReport', () => { ).not.toBeInTheDocument(); }); + it('renders married, one eligible, one ineligible with no requests', async () => { + const { findByText, findByTestId } = render( + , + ); + + expect(await findByTestId('one-ineligible')).toBeInTheDocument(); + expect( + await findByText(/our records indicate that you have not applied for/i), + ).toBeInTheDocument(); + }); + + it('renders married, one eligible, one ineligible with approved request', async () => { + const { findByText, findByTestId } = render( + , + ); + + expect(await findByTestId('one-ineligible')).toBeInTheDocument(); + expect( + await findByText(/our records indicate that you have an approved/i), + ).toBeInTheDocument(); + }); + it('renders married, pending, no approved correctly', async () => { const { findByText } = render(