Skip to content

Bug Report: Mis-assignment of k_min/k_max in get_FPT_bias() #21

@junzhou502

Description

@junzhou502

Filepath: ./external_modules/code/cosmolike/pt_cfastpt.c

Location:

void get_FPT_bias(void) 
{
  static double cache[MAX_SIZE_ARRAYS];

  if (fdiff(cache[1], Ntable.random))
  {
    FPTIA.k_min     = 1.e-5;  //<-🚨 alert
    FPTIA.k_max     = 1.e+5; //<-🚨 alert
    FPTbias.N       = 800 + 200 * Ntable.FPTboost;
    ...
  }
  if (fdiff(cache[0], cosmology.random) || fdiff(cache[1], Ntable.random))
  {
    const double dlogk = (log(FPTbias.k_max) - log(FPTbias.k_min))/FPTbias.N;
    ...
  }
}

Expected behavior:

FPTbias.k_min and FPTbias.kmax should be set 1e-5 and 1e5 instead of FPTIA.k_min and FPTIA.kmax

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions